-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(render): dim housekeeping commits by default #612
Conversation
use `LazyComment` highlight group for commits with housekeeping types, i.e. chore/ci/doc
@folke, this is just a minimal example implementation that can definitely be improved |
Perfect! I've been thinking it would be great to add a new hl group for this, but wasn't sure how to handle the fallback. |
Merged. Thank you! |
@folke, some future improvements to consider
the last two will be tricky when the log only contains such commits |
For your first point, people can already do that by changing those values in the view config module. I keep all ui related stuff in there that i don't think should be easily configurable, but can be if users want to. Keymaps etc are in there as well |
I wouldn't reorder commits. It's handy to see what changes there are in different plugins by jumping onto the repo site and scrolling through the commits, starting from the first change. If you reorder you don't know for sure which is the first change. |
you still have the timestamps. I was mostly thinking of categorizing the commits within each block, e.g. similar to https://github.com/orhun/git-cliff |
Hi, is it possible to only dim commits that aren't breaking (e.g. |
@canvanaut, it should be doable, but the question is should we actually encourage this behavior in the first place? why introduce a breaking change in a "chore" commit in the first place? 🤔 |
Oh I just used that as an example, but I've seen plenty of |
use
LazyComment
highlight group for commits with housekeeping types, i.e. chore/ci/docInspired by refined-github
Log view