Skip to content

Commit c75935b

Browse files
authored
docs(readme): fix underscore colours guide (#646)
## Description <!-- Describe the big picture of your changes to communicate to the maintainers why we should accept this pull request. --> According to [this answer](https://askubuntu.com/a/985386), `\e[58:2:R:G:Bm` is considered a "rarely used incorrect format" for truecolor. I tested it on Windows Terminal with WSL2, and it didn’t work. After changing the format to `\e[58::2:R:G:Bm`, which is noted as the "commonly used standard way," it worked as expected. The change I made is as follows: ```diff - set -as terminal-overrides ',*:Setulc=\E[58::2::%p1%{65536}%/%d::%p1%{256}%/%{255}%&%d::%p1%{255}%&%d%;m' + set -as terminal-overrides ',*:Setulc=\E[58::2::::%p1%{65536}%/%d::%p1%{256}%/%{255}%&%d::%p1%{255}%&%d%;m' ``` I’d appreciate it if someone could test this on more platforms. ## Related Issue(s) <!-- If this PR fixes any issues, please link to the issue here. - Fixes #<issue_number> --> ## Screenshots <!-- Add screenshots of the changes if applicable. -->
1 parent 2c85fad commit c75935b

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -398,7 +398,7 @@ To have undercurls show up and in color, add the following to your
398398
# Undercurl
399399
set -g default-terminal "${TERM}"
400400
set -as terminal-overrides ',*:Smulx=\E[4::%p1%dm' # undercurl support
401-
set -as terminal-overrides ',*:Setulc=\E[58::2::%p1%{65536}%/%d::%p1%{256}%/%{255}%&%d::%p1%{255}%&%d%;m' # underscore colours - needs tmux-3.0
401+
set -as terminal-overrides ',*:Setulc=\E[58::2::::%p1%{65536}%/%d::%p1%{256}%/%{255}%&%d::%p1%{255}%&%d%;m' # underscore colours - needs tmux-3.0
402402
```
403403

404404
</details>

0 commit comments

Comments
 (0)