fix(state): improve detection of mode changing #789
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will unfortunately break plugins that rely on canceling the existing operator (like flash and others). I think this is probably due to some external process that gets started with something like Need to look into a proper way of dealing with this. |
folke
pushed a commit
that referenced
this pull request
Jul 24, 2024
🤖 I have created a release *beep* *boop* --- ## [3.12.1](v3.12.0...v3.12.1) (2024-07-24) ### Bug Fixes * **node:** dynamic mappings only support functions as rhs. Fixes [#790](#790) ([ba91db7](ba91db7)) * **state:** use cached mode. Fixes [#787](#787). Closes [#789](#789) ([c1b062a](c1b062a)) * **triggers:** check for existing keymaps in the correct buffer. Fixes [#783](#783) ([977fa23](977fa23)) * **triggers:** nil error ([dae3bd2](dae3bd2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This helps improve the detection of mode changes in Neovim. It makes 2 small changes.
ModeChangedevents, things can start executing out of order a bitModeChangedevent until the event is over in some cases. This really seems like some sort of Neovim bug potentially but it is beyond me to really figure out how to debug it to formulate a real core neovim issue. To circumvent this, this takes theModeChangeevent data which specifies the old mode and new mode as a source of truth and passes that to the rest of the functionsRelated Issue(s)