Skip to content
This repository was archived by the owner on Oct 5, 2019. It is now read-only.

Commit 76093aa

Browse files
committed
add new rules
enable semi on babel plugin default enable unit-test rules for all preset default enable babel rules for react preset remove webextensions global variable support as we use mozilla/webextension-polyfill now only allow jsx on .js file because of facebook/create-react-app#87 (comment) -234627904
1 parent b3e4839 commit 76093aa

File tree

5 files changed

+193
-328
lines changed

5 files changed

+193
-328
lines changed

index.js

+5-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,11 @@
33
const extendsConfig = require('./lib/extendsConfig')
44

55
module.exports = extendsConfig({
6-
extends: ['eslint-config-airbnb/base', 'eslint-config-foray1010/rules/main'],
6+
extends: [
7+
'eslint-config-airbnb/base',
8+
'eslint-config-foray1010/rules/main',
9+
'eslint-config-foray1010/rules/unit-test'
10+
],
711
parserOptions: {
812
ecmaFeatures: {
913
// if you want to use jsx, extends "foray1010/react"

react.js

+17-1
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,17 @@ module.exports = extendsConfig({
66
extends: [
77
'eslint-config-airbnb',
88
'eslint-config-foray1010/rules/main',
9-
'eslint-config-foray1010/rules/frontend'
9+
'eslint-config-foray1010/rules/frontend',
10+
'eslint-config-foray1010/rules/babel',
11+
'eslint-config-foray1010/rules/unit-test'
1012
],
1113
settings: {
14+
'import/resolver': {
15+
node: {
16+
extensions: ['.js', '.json']
17+
}
18+
},
19+
'import/extensions': ['.js'],
1220
react: {
1321
pragma: 'createElement'
1422
}
@@ -35,6 +43,14 @@ module.exports = extendsConfig({
3543
}
3644
],
3745

46+
// do not use .jsx because of https://github.com/facebook/create-react-app/issues/87#issuecomment-234627904
47+
'react/jsx-filename-extension': [
48+
'error',
49+
{
50+
extensions: ['.js']
51+
}
52+
],
53+
3854
// ignorePureComponents because PureComponents helps improving performance and
3955
// make the flow easier to understand
4056
'react/prefer-stateless-function': [

rules/babel.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -9,14 +9,14 @@ const mainRules = extendsConfig({
99
// as these rules do not work with babel-eslint
1010
// using eslint-plugin-babel to deal with these rules
1111
const migratedRules = {}
12-
const migrateRuleNames = ['new-cap', 'no-invalid-this', 'object-curly-spacing']
12+
const migrateRuleNames = ['new-cap', 'no-invalid-this', 'object-curly-spacing', 'semi']
1313
for (const migrateRuleName of migrateRuleNames) {
1414
migratedRules[migrateRuleName] = 'off'
1515
migratedRules[`babel/${migrateRuleName}`] = mainRules.rules[migrateRuleName]
1616
}
1717

1818
module.exports = {
1919
parser: 'babel-eslint',
20-
plugins: ['babel'],
20+
plugins: ['eslint-plugin-babel'],
2121
rules: migratedRules
2222
}

rules/frontend.js

-3
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
11
'use strict'
22

33
module.exports = {
4-
env: {
5-
webextensions: true
6-
},
74
globals: {
85
document: false,
96
window: false

0 commit comments

Comments
 (0)