Skip to content

Need 'Do not show again' for the recommended extension 'Fortran IntelliSense'/'fortran-language-server' #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
phalucy opened this issue Nov 24, 2021 · 3 comments · Fixed by #304
Assignees

Comments

@phalucy
Copy link

phalucy commented Nov 24, 2021

For the current version, these two notifications appear every time when I edit my FORTRAN codes.
I need to close them every time by doing two unnecessary motions.

Please add the 'do not show again' option for these kinds of notifications.

@phalucy phalucy changed the title Need 'Do not show again' for the recommended extension Need 'Do not show again' for the recommended extension 'Fortran IntelliSense'/'fortran-language-server' Nov 24, 2021
@gnikit
Copy link
Member

gnikit commented Nov 24, 2021

I understand where you are coming from but that is intentional, because it's not a notifications it's an error/warning.

The language server protocol is how language extensions are supposed to interact with vscode. Having it, is more of a requirement rather than an option. However, because it is developed by someone other than us and is written in Python we can't just ship it with the extension so we have to notify you somehow to install it so that you can use the extension at its fullest.

The extension as a whole is moving towards integrating with the fortran-language-server internally, similar to how it is done in C/C++, so configuring big projects becomes less of a pain.

Not having the language server installed makes the extension (more or less) a text editor with syntax highlighting which is not what vscode is about.

I will consider disabling the warnings but keep in mind that the overwhelming majority of the extension's users need that message.

@phalucy
Copy link
Author

phalucy commented Nov 24, 2021

Thank you very much for replying.

I think you might slightly misunderstand what I meant.

It is really good to see those warnings when someone opens the vscode and edits Fortran code for the first time, but not 'every time'. I think it makes no hurt to add a 'do not show again' option (or button) like those notifications from Vscode itself, which just provides an option to the minority of the users who really wants to use vscode as a text editor.

Thank you again for developing this wonderful extension.

Best :)

@gnikit
Copy link
Member

gnikit commented Nov 24, 2021

So these error messages should only pop-up (every time) if you don't have the accompanying extension. As I mentioned before it is more or less a requirement to have it. If you have Fortran Intellisense these warnings should disappear.

I will add an option to disable them. FYI in the next big release 3.0.0 we won't be needing Fortran Intellisense at all, just fortls. There is already a PR #293 that does this.

@gnikit gnikit self-assigned this Nov 24, 2021
@gnikit gnikit linked a pull request Nov 24, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants