Skip to content

feat: use vscode.Tasks for downloading #608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 task done
gnikit opened this issue Aug 10, 2022 · 0 comments · Fixed by #610
Closed
1 task done

feat: use vscode.Tasks for downloading #608

gnikit opened this issue Aug 10, 2022 · 0 comments · Fixed by #610
Assignees
@gnikit
Labels
feature-request

Comments

@gnikit
Copy link
Member

gnikit commented Aug 10, 2022

Is there an existing request for this?

  • I have searched the existing issues

Feature Request

Instead of calling child_process.spawn or spawnSync for downloading pip packages we should instead attempt to use a vscode.Task and a vscode.ShellExecution. This has the added benefit of being able to inherit variables that are initialised only in the default terminal sessions.

This also sets the ground work for FPM task integration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gnikit gnikit

Labels
feature-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: uses a vscode.Task for downloading fortran-lang/vscode-fortran-support
1 participant
@gnikit