Skip to content

Commit 55ae926

Browse files
committed
Use tuple for default ROI_table_names value in copy_ome_zarr (ref #448)
1 parent 8a5af24 commit 55ae926

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

fractal_tasks_core/__FRACTAL_MANIFEST__.json

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -254,6 +254,10 @@
254254
},
255255
"ROI_table_names": {
256256
"title": "Roi Table Names",
257+
"default": [
258+
"FOV_ROI_table",
259+
"well_ROI_table"
260+
],
257261
"type": "array",
258262
"items": {
259263
"type": "string"

fractal_tasks_core/tasks/copy_ome_zarr.py

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
from pathlib import Path
1919
from typing import Any
2020
from typing import Dict
21-
from typing import Optional
2221
from typing import Sequence
2322

2423
import anndata as ad
@@ -46,7 +45,7 @@ def copy_ome_zarr(
4645
metadata: Dict[str, Any],
4746
project_to_2D: bool = True,
4847
suffix: str = "mip",
49-
ROI_table_names: Optional[Sequence[str]] = None,
48+
ROI_table_names: tuple[str, ...] = ("FOV_ROI_table", "well_ROI_table"),
5049
) -> Dict[str, Any]:
5150

5251
"""
@@ -111,10 +110,6 @@ def copy_ome_zarr(
111110
# FIXME create a standard suffix (with timestamp)
112111
raise NotImplementedError
113112

114-
if ROI_table_names is None:
115-
# FIXME: are these defaults OK?
116-
ROI_table_names = ["FOV_ROI_table", "well_ROI_table"]
117-
118113
# List all plates
119114
in_path = Path(input_paths[0])
120115
list_plates = [p.as_posix() for p in Path(in_path).glob("*.zarr")]

0 commit comments

Comments
 (0)