Skip to content

Parse Yokogawa data with overlap #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jluethi opened this issue Sep 2, 2022 · 4 comments
Closed

Parse Yokogawa data with overlap #10

jluethi opened this issue Sep 2, 2022 · 4 comments
Labels
Priority Important, but not the highest priority

Comments

@jluethi
Copy link
Collaborator

jluethi commented Sep 2, 2022

When parsing grids of yokogawa data with overlap, let's move the individual tiles such that there is no overlap.

The only thing we will initially support are grids with regular overlap. Thus, we can calculate the shift that will be necessary and ensure that the overlap is regular after metadata parsing.

See #15 for detailed discussion of how we handle overlap and #11 for an overview of the image data modalities. This is modality # 2: Grid imaged with overlap

@jluethi jluethi added the Backlog Backlog issues we may eventually fix, but aren't a priority label Sep 7, 2022
@jluethi jluethi removed the Backlog Backlog issues we may eventually fix, but aren't a priority label Sep 7, 2022
@jluethi jluethi added the Priority Important, but not the highest priority label Oct 5, 2022
@tcompa
Copy link
Collaborator

tcompa commented Oct 18, 2022

May I ask for a recap of what is to be done on this issue?

We introduced the remove_FOV_overlaps function to remove spurious single-pixel overlaps (see #91 and #107), and this may already be very similar to what we need to handle images which are placed on a grid but do have overlaps (not necessarily single-pixel ones). We need some realistic tests to move on with that use case - as tracked in #15.

In

The only thing we will initially support are grids with regular overlap. Thus, we can calculate the shift that will be necessary and ensure that the overlap is regular after metadata parsing.

the only thing which is still missing is to "ensure that the overlap is regular". Is there some advice on how to proceed on this?
Or maybe I'm missing the point of this issue, and a clarification would be most welcome :)

@jluethi
Copy link
Collaborator Author

jluethi commented Oct 19, 2022

The next thing to be done here is that we get a reasonable, small, real-world test set to check whether the current implementation already works. I've seen that it fails when there is some non-regular overlap (see #110). That's fine, because that's the current scope. I wonder though whether with the 1 pixel shifts, this actually won't hold up as well and also run into this error by chance?
=> to be tested! :) Maybe it already works well, we need to get a fitting dataset @gusqgm :)

@gusqgm
Copy link

gusqgm commented Oct 28, 2022

Hey there!
just added information on this test dataset. It has 50 pixel overlap between FOV's, so it will be interesting to test run it and see if Fractal manages to put FOV's side by side. more information can be found in the list. Curious to see its output!

@jluethi
Copy link
Collaborator Author

jluethi commented Dec 13, 2022

This is working well now. Fractal parses images with overlap, moves them so that they are just next to each other, but keeps track of the original positions in the FOV_ROI table.

See here for the example of this running for the dataset mentioned above: https://github.com/fractal-analytics-platform/fractal-demos/tree/fb71f0e03b77eb7d6ada92e42e7674c9cf64375e/examples-v1/17_Overlap

It then looks like this (a small shift between the two FOVs because we imaged with overlap):
Ome_Zarr_overlap_zoom_in

Or like this as an overview:
Ome_zarr_overlap_overview

@jluethi jluethi closed this as completed Dec 13, 2022
Repository owner moved this from TODO to Done in Fractal Project Management Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority Important, but not the highest priority
Projects
Archived in project
Development

No branches or pull requests

3 participants