-
Notifications
You must be signed in to change notification settings - Fork 7
Parse Yokogawa data with overlap #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
May I ask for a recap of what is to be done on this issue? We introduced the In
the only thing which is still missing is to "ensure that the overlap is regular". Is there some advice on how to proceed on this? |
The next thing to be done here is that we get a reasonable, small, real-world test set to check whether the current implementation already works. I've seen that it fails when there is some non-regular overlap (see #110). That's fine, because that's the current scope. I wonder though whether with the 1 pixel shifts, this actually won't hold up as well and also run into this error by chance? |
Hey there! |
This is working well now. Fractal parses images with overlap, moves them so that they are just next to each other, but keeps track of the original positions in the FOV_ROI table. See here for the example of this running for the dataset mentioned above: https://github.com/fractal-analytics-platform/fractal-demos/tree/fb71f0e03b77eb7d6ada92e42e7674c9cf64375e/examples-v1/17_Overlap It then looks like this (a small shift between the two FOVs because we imaged with overlap): |
Uh oh!
There was an error while loading. Please reload this page.
When parsing grids of yokogawa data with overlap, let's move the individual tiles such that there is no overlap.
The only thing we will initially support are grids with regular overlap. Thus, we can calculate the shift that will be necessary and ensure that the overlap is regular after metadata parsing.
See #15 for detailed discussion of how we handle overlap and #11 for an overview of the image data modalities. This is modality # 2: Grid imaged with overlap
The text was updated successfully, but these errors were encountered: