Skip to content

Get gridless test set to pass #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jluethi opened this issue Sep 27, 2022 · 3 comments
Closed

Get gridless test set to pass #109

jluethi opened this issue Sep 27, 2022 · 3 comments
Assignees
Labels
Priority Important, but not the highest priority

Comments

@jluethi
Copy link
Collaborator

jluethi commented Sep 27, 2022

When trying to run the gridless test case UZH path: /data/active/fractal/Liberali/FractalTesting20220124/gridless_Yokogawa_recording-FMI/20220316_sec_FOCM_test-R1_E2/day3/TIF (number 4 of search first here: fractal-analytics-platform/fractal-client#213), the metadata parsing fails with the error message:
Exception: When parsing the Yokogawa mlf file, some sites had varying step size in Z. That is not supported for the OME-Zarr parsing

Let's check whether this is really the problem or whether something in the metadata parsing is failing for this file. Could be an issue when the metadata was created for this test set, could be a parsing problem.

@jluethi
Copy link
Collaborator Author

jluethi commented Oct 13, 2022

Digging into this, the problem again is float precision. In this case, the steps are of size 0.6 um. Thus, represented as floats. That means that sometimes they are 0.5999999999999979, sometimes they are 0.6000000000000014. I'll need to adapt the parsing to be robust against this.

@jluethi
Copy link
Collaborator Author

jluethi commented Oct 14, 2022

Test again now that #136 fixes the precision issue.

@jluethi
Copy link
Collaborator Author

jluethi commented Oct 14, 2022

With the metadata fix, the gridless search first now works as expected! 🎉
See 3f5c8b884683e881a6b07e058ef3b03348f9772e for the example
Bildschirmfoto 2022-10-14 um 19 36 15

Overexposed (same image, but shows borders of FOVs):
Bildschirmfoto 2022-10-14 um 19 33 34

@jluethi jluethi closed this as completed Oct 14, 2022
Repository owner moved this from TODO to Done in Fractal Project Management Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority Important, but not the highest priority
Projects
Archived in project
Development

No branches or pull requests

1 participant