Skip to content

Parsing Yokogawa data with pandas table as metadata inputs #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jluethi opened this issue Jul 28, 2022 · 2 comments · Fixed by #252
Closed

Parsing Yokogawa data with pandas table as metadata inputs #14

jluethi opened this issue Jul 28, 2022 · 2 comments · Fixed by #252
Assignees
Labels
enhancement New feature or request High Priority Current Priorities & Blocking Issues

Comments

@jluethi
Copy link
Collaborator

jluethi commented Jul 28, 2022

There are 3 main ways to parse the metadata for a Yokogawa dataset:

  1. The dataset has the MeasurementData.mlf and MeasurementDetail.mrf, it's being parsed to define ROIs. (our current implementation)
  2. The user creates their own pandas table that follows the same specification (very useful to allow users with special cases a path into Fractal)
  3. The somewhat simple case of full rectangular wells (like most of our test cases so far). Based on very few parameters (pixel sizes, bit depth, grid dimensions & image sizes), we can calculate all the metadata parameters for this simple case without needing metadata files or dataframes. => Create basic yokogawa_to_zarr parsing from minimal inputs (no metadata files, no table) #47

This issue describes case 2


Our current parsing method for the yokogawa relies on the MeasurementData.mlf & the MeasurementDetail.mrf file. Those are parsed to define the ROIs (see here: #25) and we generate a table like this:
Screenshot 2022-07-21 at 17 11 33

From that table, the relevant metadata is then assigned to each ROI and ROIs get coordinates assigned (that are saved to the AnnData table per well).

We should create a second parsing function (/an alternative input to the parsing function) that allow users to pass a pandas dataframe (either pass a dataframe or pass a path to a csv file) directly to the parsing function, such that it takes this table & assigns ROIs based on the table.

Testcase TBD. I will create a test case for the single-well, 2x2 scenario

@jluethi jluethi changed the title Parsing Yokogawa data with alternative metadata inputs Parsing Yokogawa data with pandas table as metadata inputs Jul 28, 2022
@jluethi jluethi added the enhancement New feature or request label Jul 28, 2022
@jluethi jluethi transferred this issue from fractal-analytics-platform/fractal-client Sep 2, 2022
@jluethi jluethi added the Backlog Backlog issues we may eventually fix, but aren't a priority label Sep 7, 2022
@jluethi
Copy link
Collaborator Author

jluethi commented Sep 27, 2022

Let's reassess this based on how the table may change. One idea is to parse filenames from the metadata file as well to make parsing more robust. This would make this idea harder to implement.

@tcompa
Copy link
Collaborator

tcompa commented Dec 2, 2022

  • Allow two usage modes: either reading mlf/mrf files or passing a csv path to site_metadata.
  • Fail otherwise
  • Rename arg to microscope_metadata

Note: this is not related to #47.

@tcompa tcompa added High Priority Current Priorities & Blocking Issues and removed Backlog Backlog issues we may eventually fix, but aren't a priority labels Dec 2, 2022
Repository owner moved this from Backlog to Done in Fractal Project Management Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request High Priority Current Priorities & Blocking Issues
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants