Skip to content

Support ROI tables that don't start at 0,0,0 #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #106
jluethi opened this issue Sep 19, 2022 · 0 comments · Fixed by #106
Closed
Tracked by #106

Support ROI tables that don't start at 0,0,0 #82

jluethi opened this issue Sep 19, 2022 · 0 comments · Fixed by #106
Labels
Backlog Backlog issues we may eventually fix, but aren't a priority Tables AnnData and ROI/feature tables

Comments

@jluethi
Copy link
Collaborator

jluethi commented Sep 19, 2022

Currently, the parsing shifts ROIs to start at 0, 0, 0. We will have cases where this isn't possible anymore or hasn't been done. e.g. using external OME-Zarr files with ROIs, processing ROIs during multiplexing (when ROIs may shift due to registration), maybe changes during stitching of images within wells.

Additionally, when we start using ROIs for e.g. Organoids, they will not necessarily start at 0, 0, 0. Not an issue for illumination correction, but let's not make the 0, 0, 0 assumptions for e.g. labeling.

For now, the 0, 0, 0 is a good start. See #8 (comment) for details.

Let's use this issue to track that we may need to change this, e.g. when implementing registration for multiplexing.

@tcompa tcompa mentioned this issue Sep 27, 2022
6 tasks
@jluethi jluethi added the Backlog Backlog issues we may eventually fix, but aren't a priority label Sep 28, 2022
@tcompa tcompa added the Tables AnnData and ROI/feature tables label Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backlog Backlog issues we may eventually fix, but aren't a priority Tables AnnData and ROI/feature tables
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants