Skip to content

Commit fa6ddc4

Browse files
shiba-codeslena
and
lena
authored
InlineSpinner fixes (#306)
* fix(inline-spinner): fix invalid html * feat(inline-spinner): add role=progressbar * test(inline-spinner): update snapshots --------- Co-authored-by: lena <[email protected]>
1 parent c60ae86 commit fa6ddc4

File tree

2 files changed

+14
-8
lines changed

2 files changed

+14
-8
lines changed

src/components/InlineSpinner/InlineSpinner.tsx

+2-2
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ const rotation = keyframes`
3737
}
3838
`;
3939

40-
const InlineSpinnerIcon: React.FC<InlineSpinnerProps> = styled.div<InlineSpinnerProps>`
40+
const InlineSpinnerIcon: React.FC<InlineSpinnerProps> = styled.span<InlineSpinnerProps>`
4141
display: inline-block;
4242
box-sizing: border-box;
4343
width: 1.25rem;
@@ -52,7 +52,7 @@ const InlineSpinnerIcon: React.FC<InlineSpinnerProps> = styled.div<InlineSpinner
5252
`;
5353

5454
const InlineSpinner: FC<InlineSpinnerProps> = (props: InlineSpinnerProps) => (
55-
<span>
55+
<span role="progressbar">
5656
<InlineSpinnerIcon {...props} />
5757
</span>
5858
);

src/components/InlineSpinner/__snapshots__/InlineSpinner.spec.tsx.snap

+12-6
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,10 @@ exports[`InlineSpinner renders in a custom color 1`] = `
1717
border-width: 0.125rem;
1818
}
1919
20-
<span>
21-
<div
20+
<span
21+
role="progressbar"
22+
>
23+
<span
2224
class="c0"
2325
color="#069D4F"
2426
/>
@@ -42,8 +44,10 @@ exports[`InlineSpinner renders the default variant 1`] = `
4244
border-width: 0.125rem;
4345
}
4446
45-
<span>
46-
<div
47+
<span
48+
role="progressbar"
49+
>
50+
<span
4751
class="c0"
4852
color="#001E3E"
4953
/>
@@ -67,8 +71,10 @@ exports[`InlineSpinner renders the small size 1`] = `
6771
border-width: 0.1rem;
6872
}
6973
70-
<span>
71-
<div
74+
<span
75+
role="progressbar"
76+
>
77+
<span
7278
class="c0"
7379
color="#001E3E"
7480
/>

0 commit comments

Comments
 (0)