Skip to content

Refactor colors to have one source of truth #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 tasks
Tracked by #121
nlopin opened this issue Jan 28, 2022 · 0 comments · Fixed by #208
Closed
2 tasks
Tracked by #121

Refactor colors to have one source of truth #202

nlopin opened this issue Jan 28, 2022 · 0 comments · Fixed by #208
Labels
enhancement New feature or request

Comments

@nlopin
Copy link
Contributor

nlopin commented Jan 28, 2022

Related to #121

Currently, colors are hardcoded twice in the Colors.ts — for deprecated Colors enum and for semanticColors object. This needs to be refactored to keep only one set of color hexes in the code.

Criteria

  • The API must not change
  • semanticColors must be the source of truth
@nlopin nlopin added the enhancement New feature or request label Jan 28, 2022
@nlopin nlopin mentioned this issue Jan 28, 2022
Closed
6 tasks
@nlopin nlopin linked a pull request Feb 24, 2022 that will close this issue
Remove brand colors from semantic tokens #208
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove brand colors from semantic tokens freenowtech/wave
1 participant
@nlopin