Skip to content

Label is missing children type definition #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
arturmiglio opened this issue May 10, 2023 · 1 comment · Fixed by #340
Closed

Label is missing children type definition #332

arturmiglio opened this issue May 10, 2023 · 1 comment · Fixed by #340
Labels
bug Something isn't working

Comments

@arturmiglio
Copy link
Contributor

Label props don't include children definition.

Relevant code

<Label>
    Text
</Label>

What was expected to happen?

No TS error:

Type '{ children: string; }' has no properties in common with type 'IntrinsicAttributes & LabelProps'.

Reproduction

https://codesandbox.io/s/elastic-ully-vnv96e
@arturmiglio arturmiglio added the bug Something isn't working label May 10, 2023
@rasidre
Copy link
Contributor

rasidre commented Jun 9, 2023

@arturmiglio here is a suggestion to solve this TS message: #340

@nlopin nlopin linked a pull request Jun 12, 2023 that will close this issue
fix: add support for children props inside Label component #340
Merged
@jonotrujillo jonotrujillo mentioned this issue Jul 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add support for children props inside Label component rasidre/wave
2 participants
@arturmiglio @rasidre