Skip to content

Add a DatetimeRange dataclass to pass pairs from/to #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Marenz opened this issue Feb 19, 2024 · 3 comments
Open

Add a DatetimeRange dataclass to pass pairs from/to #15

Marenz opened this issue Feb 19, 2024 · 3 comments
Labels
part:client Affects the client code part:❓ We need to figure out which part is affected priority:low This should be addressed only if there is nothing else on the table scope:breaking-change Breaking change, users will need to update their code type:enhancement New feature or enhancement visitble to users

Comments

@Marenz
Copy link
Contributor

Marenz commented Feb 19, 2024

What's needed?

add a DatetimeRange dataclass to pass pairs from/to.

Proposed solution

No response

Use cases

No response

Alternatives and workarounds

No response

Additional context

No response

@Marenz Marenz added part:❓ We need to figure out which part is affected priority:❓ We need to figure out how soon this should be addressed type:enhancement New feature or enhancement visitble to users labels Feb 19, 2024
@llucax
Copy link
Contributor

llucax commented Feb 19, 2024

I wonder if this could be useful for other teams, so if we should put it in api-common (if we make it directly a type of proto message) or base-client instead if we keep it as a python-only thing.

@frequenz-floss/api-team does anyone envision having to use datetime ranges in other APIs? I guess for reporting if you are requesting data for a range you'll also have to specify a range, right?

@noah-kreutzer-frequenz
Copy link

@frequenz-floss/api-team does anyone envision having to use datetime ranges in other APIs? I guess for reporting if you are requesting data for a range you'll also have to specify a range, right?

the weatehr client is using a list of datetime objects to specify the time of the forcasts to be filtered out.
But for now a list with explicit timestamps is implemented. I'm not sure if ranges in combinations of ranges and timedeltas could be of interest for further development. What do you think @cwasicki?

@llucax llucax changed the title add a DatetimeRange dataclass to pass pairs from/to. Add a DatetimeRange dataclass to pass pairs from/to. Feb 20, 2024
@llucax llucax changed the title Add a DatetimeRange dataclass to pass pairs from/to. Add a DatetimeRange dataclass to pass pairs from/to Feb 20, 2024
@cwasicki
Copy link

In my opinion for weather it can make sense to simplify the query to datetime ranges. Also, ranges are used in other APIs like reporting and I think trading.

@Marenz Marenz added priority:low This should be addressed only if there is nothing else on the table scope:breaking-change Breaking change, users will need to update their code and removed priority:❓ We need to figure out how soon this should be addressed labels Jun 21, 2024
@llucax llucax added the part:client Affects the client code label Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
part:client Affects the client code part:❓ We need to figure out which part is affected priority:low This should be addressed only if there is nothing else on the table scope:breaking-change Breaking change, users will need to update their code type:enhancement New feature or enhancement visitble to users
Projects
None yet
Development

No branches or pull requests

4 participants