Skip to content

Google/Facebook sign in page looks like not mobile friendly #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ujeenator opened this issue Aug 28, 2017 · 8 comments
Open

Google/Facebook sign in page looks like not mobile friendly #153

ujeenator opened this issue Aug 28, 2017 · 8 comments

Comments

@ujeenator
Copy link

I'm testing on Nexus 5 screen and buttons on Facebook/Google sign in page are out of the screen, and you need to scroll horizontally to press them.

I'm sure there is a mobile friendly version of these pages, recently I have used "react-native-simple-auth" module, it opens same pages not in WebView, but in external browser app, and these pages perfectly fits screen width.

@ujeenator
Copy link
Author

screen shot 2017-08-28 at 10 53 11 pm

screen shot 2017-08-28 at 10 52 06 pm

@jslok
Copy link

jslok commented Aug 31, 2017

+1

1 similar comment
@tinchogon34
Copy link

+1

@qispark
Copy link

qispark commented Sep 8, 2017

Hey, I've made a pull request which I think fixes this - Facebook login is now showing up correctly on my Android device.

Could someone test this for the Google sign in page?

@bufke
Copy link

bufke commented Sep 8, 2017

I didn't test Google but can confirm @qispark's PR helps a lot. It still has issues on changing orientation but that isn't related to the user agent string being set.

@jslok
Copy link

jslok commented Sep 9, 2017

@qispark with your change the google sign in page shows the disallowed useragent page and doesn't allow login.

Changing line 112 to mWebView.getSettings().setUserAgentString("Mozilla/5.0 (Linux; Android 6.0.1; SM-G920V Build/MMB29K) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2743.98 Mobile Safari/537.36"); seems to make both facebook and google mobile-friendly on my S6.

@ujeenator
Copy link
Author

ujeenator commented Sep 25, 2017

It looks like there no need to mess around with user agent

Web view already have it own user agent string

I have just commented line that changes webView's user agent and it works perfectly

node_modules/react-native-oauth/android/src/main/java/io/fullstack/oauth/OAuthManagerDialogFragment.java
112: // mWebView.getSettings().setUserAgentString("Mozilla/5.0 Google");

@iyogeshjoshi
Copy link

@ujeenator it seems in latest version on Android platform, you need to change user-agent in node_modules/react-native-oauth/android/src/main/java/io/fullstack/oauth/OAuthManagerDialogFragment.java 112: just like @jslok said. It seems to fix the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants