-
Notifications
You must be signed in to change notification settings - Fork 214
Google/Facebook sign in page looks like not mobile friendly #153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
+1 |
1 similar comment
+1 |
Hey, I've made a pull request which I think fixes this - Facebook login is now showing up correctly on my Android device. Could someone test this for the Google sign in page? |
I didn't test Google but can confirm @qispark's PR helps a lot. It still has issues on changing orientation but that isn't related to the user agent string being set. |
@qispark with your change the google sign in page shows the disallowed useragent page and doesn't allow login. Changing line 112 to |
It looks like there no need to mess around with user agent Web view already have it own user agent string I have just commented line that changes webView's user agent and it works perfectly node_modules/react-native-oauth/android/src/main/java/io/fullstack/oauth/OAuthManagerDialogFragment.java |
@ujeenator it seems in latest version on Android platform, you need to change user-agent in |
I'm testing on Nexus 5 screen and buttons on Facebook/Google sign in page are out of the screen, and you need to scroll horizontally to press them.
I'm sure there is a mobile friendly version of these pages, recently I have used "react-native-simple-auth" module, it opens same pages not in WebView, but in external browser app, and these pages perfectly fits screen width.
The text was updated successfully, but these errors were encountered: