Skip to content
This repository was archived by the owner on May 17, 2019. It is now read-only.

Blocked updates when using router and styletron plugins #112

Closed
KevinGrandon opened this issue May 12, 2018 · 2 comments
Closed

Blocked updates when using router and styletron plugins #112

KevinGrandon opened this issue May 12, 2018 · 2 comments

Comments

@KevinGrandon
Copy link
Contributor

KevinGrandon commented May 12, 2018

Type of issue

Bug

Description

Including the fusion-plugin-styletron-react plugin will block react router updates occasionally.

Current behavior

I'm still working on a STR here, but it seems that including fusion-plugin-styletron-react will cause the router plugin to stop working. Links can be clicked which will update the browser URL, but the component does not render.

It feels like a symptom of: https://github.com/ReactTraining/react-router/blob/master/packages/react-router/docs/guides/blocked-updates.md

Expected behavior

Everything works as normal.

Your environment

I'll try to implement a minimal reproducible repository.

Interesting note:

This reproduces with code like:

app.register(Styletron);
app.register(Router);

If you simply swap the order, the issue goes away:

app.register(Router);
app.register(Styletron);
@rtsao
Copy link
Contributor

rtsao commented May 15, 2018

I think this has to do with: remix-run/react-router#6072
(Styletron uses React.createContext API in React 16.3 via create-react-context)

@rtsao
Copy link
Contributor

rtsao commented May 24, 2018

Should be resolved in React 16.4
facebook/react#12551

@mlmorg mlmorg closed this as completed Mar 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants