Added more tests for copying

Author: Skarlso

Diff for: pipeline/build_golang_test.go

@@ -3,6 +3,7 @@ package pipeline
 import (
 	"context"
 	"fmt"
+	"io/ioutil"
 	"os"
 	"os/exec"
 	"path/filepath"
@@ -36,7 +37,8 @@ func fakeExecCommandContext(ctx context.Context, name string, args ...string) *e
 		envArgs = arg
 	}
 	os.Setenv("CMD_ARGS", envArgs)
-	cmd.Env = []string{"GO_WANT_HELPER_PROCESS=1"}
+	es := strconv.Itoa(mockedStatus)
+	cmd.Env = []string{"GO_WANT_HELPER_PROCESS=1", "EXIT_STATUS=" + es}
 	return cmd
 }
 
@@ -45,7 +47,8 @@ func TestExecCommandContextHelper(t *testing.T) {
 		return
 	}
 	fmt.Fprintln(os.Stdout, mockedOutput)
-	os.Exit(mockedStatus)
+	i, _ := strconv.Atoi(os.Getenv("EXIT_STATUS"))
+	os.Exit(i)
 }
 
 func TestPrepareEnvironment(t *testing.T) {
@@ -87,26 +90,15 @@ func TestExecuteBuild(t *testing.T) {
 	if err != nil {
 		t.Fatal("error while running executebuild. none was expected")
 	}
-	expectedOut := ""
-	actualOut := os.Getenv("STDOUT")
-	expectedStatus := 0
-	actualStatus, _ := strconv.Atoi(os.Getenv("EXIT_STATUS"))
 	expectedArgs := "-test.run=TestExecCommandContextHelper,--,/usr/local/bin/go,get,-d,./...:-test.run=TestExecCommandContextHelper,--,/usr/local/bin/go,build,-o,_"
 	actualArgs := os.Getenv("CMD_ARGS")
-	if expectedOut != actualOut {
-		t.Fatalf("expected out '%s' actual out '%s'", expectedOut, actualOut)
-	}
-	if expectedStatus != actualStatus {
-		t.Fatalf("expected status '%d' actual status '%d'", expectedStatus, actualStatus)
-	}
 	if expectedArgs != actualArgs {
 		t.Fatalf("expected args '%s' actual args '%s'", expectedArgs, actualArgs)
 	}
 }
 
 func TestExecuteBuildContextTimeout(t *testing.T) {
 	execCommandContext = fakeExecCommandContext
-	mockedOutput = "mocked output\n"
 	killContext = true
 	defer func() { execCommandContext = exec.CommandContext }()
 	defer func() { killContext = false }()
@@ -145,11 +137,45 @@ func TestCopyBinary(t *testing.T) {
 	p.Pipeline.Name = "main"
 	p.Pipeline.Type = "go"
 	p.Pipeline.Repo.LocalDest = tmp
-	f, _ := os.Create(filepath.Join(tmp, appendTypeToName(p.Pipeline.Name, p.Pipeline.Type)))
+	src := filepath.Join(tmp, appendTypeToName(p.Pipeline.Name, p.Pipeline.Type))
+	dst := appendTypeToName(p.Pipeline.Name, p.Pipeline.Type)
+	f, _ := os.Create(src)
 	defer f.Close()
-	defer os.Remove(appendTypeToName(p.Pipeline.Name, p.Pipeline.Type))
+	defer os.Remove(dst)
+	ioutil.WriteFile(src, []byte("testcontent"), 0666)
 	err := b.CopyBinary(p)
 	if err != nil {
 		t.Fatal("error was not expected when copying binary: ", err)
 	}
+	content, err := ioutil.ReadFile(dst)
+	if err != nil {
+		t.Fatal("error encountered while reading destination file: ", err)
+	}
+	if string(content) != "testcontent" {
+		t.Fatal("file content did not equal src content. was: ", string(content))
+	}
+}
+
+func TestCopyBinarySrcDoesNotExist(t *testing.T) {
+	tmp := os.TempDir()
+	gaia.Cfg = new(gaia.Config)
+	gaia.Cfg.HomePath = tmp
+	// Initialize shared logger
+	gaia.Cfg.Logger = hclog.New(&hclog.LoggerOptions{
+		Level:  hclog.Trace,
+		Output: hclog.DefaultOutput,
+		Name:   "Gaia",
+	})
+	b := new(BuildPipelineGolang)
+	p := new(gaia.CreatePipeline)
+	p.Pipeline.Name = "main"
+	p.Pipeline.Type = "go"
+	p.Pipeline.Repo.LocalDest = "/noneexistent"
+	err := b.CopyBinary(p)
+	if err == nil {
+		t.Fatal("error was expected when copying binary but none occurred ")
+	}
+	if err.Error() != "open /noneexistent/main_go: no such file or directory" {
+		t.Fatal("a different error occurred then expected: ", err)
+	}
 }

Diff for: pipeline/git_test.go

@@ -9,7 +9,7 @@ import (
 
 func TestGitCloneRepo(t *testing.T) {
 	repo := &gaia.GitRepo{
-		URL:       "https://github.com/gaia-pipeline/gaia",
+		URL:       "https://github.com/gaia-pipeline/go-test-example",
 		LocalDest: "tmp",
 	}
 	// always ensure that tmp folder is cleaned up