fix: make require-exact-type ignore indexers in map types (#354)

geraintwhite · gajus · commit 07221872e0c7 · 2018-09-18T23:03:52.000+01:00
diff --git a/src/rules/requireExactType.js b/src/rules/requireExactType.js
@@ -10,10 +10,10 @@ const create = (context) => {
 
   return {
     TypeAlias (node) {
-      const {id: {name}, right: {type, exact}} = node;
+      const {id: {name}, right: {type, exact, indexers}} = node;
 
       if (type === 'ObjectTypeAnnotation') {
-        if (always && !exact) {
+        if (always && !exact && indexers.length === 0) {
           context.report({
             data: {name},
             message: 'Type identifier \'{{name}}\' must be exact.',
diff --git a/tests/rules/assertions/requireExactType.js b/tests/rules/assertions/requireExactType.js
@@ -69,6 +69,9 @@ export default {
     {
       code: 'type foo = {| bar: string |};'
     },
+    {
+      code: 'type foo = { [key: string]: string };'
+    },
     {
       code: 'type foo = number;'
     },

Original file line number	Diff line number	Diff line change
`@@ -69,6 +69,9 @@ export default {`
`69`	`69`	`{`
`70`	`70`	`code: 'type foo = {\| bar: string \|};'`
`71`	`71`	`},`
	`72`	`+ {`
	`73`	`+ code: 'type foo = { [key: string]: string };'`
	`74`	`+ },`
`72`	`75`	`{`
`73`	`76`	`code: 'type foo = number;'`
`74`	`77`	`},`