Skip to content

Commit 90cc626

Browse files
committed
Fix secret access in slots
1 parent 46206c5 commit 90cc626

File tree

2 files changed

+21
-14
lines changed

2 files changed

+21
-14
lines changed

frontend/src/utils/index.js

+3
Original file line numberDiff line numberDiff line change
@@ -299,6 +299,9 @@ export function getTimeStringTo (time, toTime, withoutPrefix = false) {
299299
}
300300

301301
export function isOwnSecretBinding (secret) {
302+
if (!secret) {
303+
return false
304+
}
302305
return get(secret, 'metadata.namespace') === get(secret, 'metadata.bindingNamespace')
303306
}
304307

frontend/src/views/Secrets.vue

+18-14
Original file line numberDiff line numberDiff line change
@@ -74,8 +74,10 @@ limitations under the License.
7474
@update="onUpdate"
7575
@delete="onDelete"
7676
>
77-
<template v-if="isOwnSecretBinding(secret)" v-slot:rowSubTitle="{ secret }">
78-
{{secret.data.domainName}} / {{secret.data.tenantName}}
77+
<template v-slot:rowSubTitle="{ secret }">
78+
<template v-if="isOwnSecretBinding(secret)">
79+
{{secret.data.domainName}} / {{secret.data.tenantName}}
80+
</template>
7981
</template>
8082
</secret>
8183

@@ -123,18 +125,20 @@ limitations under the License.
123125
@update="onUpdate"
124126
@delete="onDelete"
125127
>
126-
<template v-if="isOwnSecretBinding(secret)" v-slot:rowSubTitle="{ secret }">
127-
<v-tooltip top>
128-
<template v-slot:activator="{ on }">
129-
<span v-on="on">{{secret.data.vsphereUsername}}</span>
130-
</template>
131-
<span>vSphere Username</span>
132-
</v-tooltip> / <v-tooltip top>
133-
<template v-slot:activator="{ on }">
134-
<span v-on="on">{{secret.data.nsxtUsername}}</span>
135-
</template>
136-
<span>NSX-T Username</span>
137-
</v-tooltip>
128+
<template v-slot:rowSubTitle="{ secret }">
129+
<template v-if="isOwnSecretBinding(secret)">
130+
<v-tooltip top>
131+
<template v-slot:activator="{ on }">
132+
<span v-on="on">{{secret.data.vsphereUsername}}</span>
133+
</template>
134+
<span>vSphere Username</span>
135+
</v-tooltip> / <v-tooltip top>
136+
<template v-slot:activator="{ on }">
137+
<span v-on="on">{{secret.data.nsxtUsername}}</span>
138+
</template>
139+
<span>NSX-T Username</span>
140+
</v-tooltip>
141+
</template>
138142
</template>
139143
</secret>
140144

0 commit comments

Comments
 (0)