You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Jan 20, 2025. It is now read-only.
Copy file name to clipboardExpand all lines: docs/contributing/index.md
+5-5
Original file line number
Diff line number
Diff line change
@@ -6,12 +6,12 @@ disableTableOfContents: true
6
6
7
7
Thanks for being interested in contributing! We're so glad you want to help!
8
8
9
-
Below you'll find guides on the Gatsby.js community, code of conduct, and how to get started contributing:
9
+
Below you'll find guides on the Gatsby community, code of conduct, and how to get started contributing:
10
10
11
-
-[Community](/contributing/community/): Learn why you should contribute to Gatsby.js, the most effective ways to do so, and all about the benefits (did we mention the free swag?)
12
-
-[Code of Conduct](/contributing/code-of-conduct/): Read about what we expect from everyone participating in Gatsby.js to make it the most friendly and welcoming community
11
+
-[Community](/contributing/community/): Learn why you should contribute to Gatsby, the most effective ways to do so, and all about the benefits (did we mention the free swag?)
12
+
-[Code of Conduct](/contributing/code-of-conduct/): Read about what we expect from everyone participating in Gatsby to make it the most friendly and welcoming community
13
13
-[Gatsby Style Guide](/contributing/gatsby-style-guide/): The art of contributing to Gatsby, a.k.a. the detailed requirements that will make it more likely your contribution is accepted with minimal changes
14
-
-[How to Contribute](/contributing/how-to-contribute/): How to get the most out of your Gatsby.js contributing experience, including GitHub management tips, setup instructions for docs and code contributions, and more
15
-
-[RFC process](/contributing/rfc-process): Learn how the Gatsby.js team manages bigger changes, by way of a “Request-for-comment” process on GitHub
14
+
-[How to Contribute](/contributing/how-to-contribute/): How to get the most out of your Gatsby contributing experience, including GitHub management tips, setup instructions for docs and code contributions, and more
15
+
-[RFC process](/contributing/rfc-process): Learn how the Gatsby team manages bigger changes, by way of a “Request-for-comment” process on GitHub
16
16
17
17
<EmailCaptureFormsignupMessage="Want to keep up with the latest tips & tricks? Subscribe to our newsletter!" />
Copy file name to clipboardExpand all lines: docs/docs/how-shadowing-works.md
+4-4
Original file line number
Diff line number
Diff line change
@@ -283,7 +283,7 @@ export default props => (
283
283
284
284
This is the first case we'll handle when attempting to resolve the file.
285
285
286
-
In order to do this we need to leverage the **issuer** of the request. This points to the file that the request came from. This means it refers to _where_ the `import` occurs.
286
+
In order to do this we need to leverage the **Issuer** of the request. This points to the file that the request came from. This means it refers to _where_ the `import` occurs.
287
287
The **request** refers to what the import points to.
288
288
289
289
This is implemented by another method on the plugin's class which we call `requestPathIsIssuerShadowPath` which has the following method signature:
`requestPathIsIssuerShadowPath` checks all possible directories for shadowing and then returns whether the issuer's path is found. Let's first take a look at the code and then unpack what's happening here.
300
+
`requestPathIsIssuerShadowPath` checks all possible directories for shadowing and then returns whether the Issuer's path is found. Let's first take a look at the code and then unpack what's happening here.
We then know that if the issuer _matches_ one of these components that it's being extended. This means that a shadowed component is extending the same component from its parent.
331
+
We then know that if the Issuer _matches_ one of these components that it's being extended. This means that a shadowed component is extending the same component from its parent.
332
332
333
333
When this happens, we return the next path, so here the original location of the theme: `/Users/johno/c/gatsby-theme-example-component-extending/gatsby-theme-tomato/src/box`.
334
334
@@ -352,7 +352,7 @@ Now, all usages of the Box in `gatsby-theme-tomato` will be also wrapped in a pu
352
352
353
353
#### An edge case
354
354
355
-
If a theme sets [`module` config](https://webpack.js.org/configuration/resolve/#resolvemodules) the issuer will be null. As such we need to first check that the `request.context.issuer` is present before we attempt to resolve the shadowed component.
355
+
If a theme sets [`module` config](https://webpack.js.org/configuration/resolve/#resolvemodules) the Issuer will be null. As such we need to first check that the `request.context.issuer` is present before we attempt to resolve the shadowed component.
356
356
357
357
It's important to note that we don't recommend appending to the modules list in themes.
358
358
Though, if you do, we will make sure we don't arbitrarily error.
0 commit comments