Skip to content

Commit 4498cab

Browse files
daveisferagerzse
authored andcommitted
Fix typing for address_remap (fixes redis#3234) (redis#3235)
The address_remap callback received a tuple with the host and the port. Make this clear in the typing hints.
1 parent ded15f2 commit 4498cab

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

redis/asyncio/cluster.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -269,7 +269,7 @@ def __init__(
269269
ssl_min_version: Optional[ssl.TLSVersion] = None,
270270
ssl_ciphers: Optional[str] = None,
271271
protocol: Optional[int] = 2,
272-
address_remap: Optional[Callable[[str, int], Tuple[str, int]]] = None,
272+
address_remap: Optional[Callable[[Tuple[str, int]], Tuple[str, int]]] = None,
273273
) -> None:
274274
if db:
275275
raise RedisClusterException(
@@ -1098,7 +1098,7 @@ def __init__(
10981098
startup_nodes: List["ClusterNode"],
10991099
require_full_coverage: bool,
11001100
connection_kwargs: Dict[str, Any],
1101-
address_remap: Optional[Callable[[str, int], Tuple[str, int]]] = None,
1101+
address_remap: Optional[Callable[[Tuple[str, int]], Tuple[str, int]]] = None,
11021102
) -> None:
11031103
self.startup_nodes = {node.name: node for node in startup_nodes}
11041104
self.require_full_coverage = require_full_coverage

redis/cluster.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -499,7 +499,7 @@ def __init__(
499499
read_from_replicas: bool = False,
500500
dynamic_startup_nodes: bool = True,
501501
url: Optional[str] = None,
502-
address_remap: Optional[Callable[[str, int], Tuple[str, int]]] = None,
502+
address_remap: Optional[Callable[[Tuple[str, int]], Tuple[str, int]]] = None,
503503
**kwargs,
504504
):
505505
"""
@@ -1310,7 +1310,7 @@ def __init__(
13101310
lock=None,
13111311
dynamic_startup_nodes=True,
13121312
connection_pool_class=ConnectionPool,
1313-
address_remap: Optional[Callable[[str, int], Tuple[str, int]]] = None,
1313+
address_remap: Optional[Callable[[Tuple[str, int]], Tuple[str, int]]] = None,
13141314
**kwargs,
13151315
):
13161316
self.nodes_cache = {}

0 commit comments

Comments
 (0)