convex-backend PR 29: Provide safety and intellisense for weekly cron job (#33124)

Adds `as const` to the `DAYS_OF_WEEK` array to make it literal. This should give type safety/intellisense when filling out `dayOfWeek` in a weekly cron job in `crons.ts`.

----

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Co-authored-by: Jan Balin <[email protected]>
GitOrigin-RevId: 7b7400324f4b9761253b9ab0a071b0ab94f9f409

Author: 2 people

Diff for: npm-packages/convex/src/server/cron.ts

@@ -31,7 +31,7 @@ const DAYS_OF_WEEK = [
   "thursday",
   "friday",
   "saturday",
-];
+] as const;
 type DayOfWeek = (typeof DAYS_OF_WEEK)[number];
 /** @public */
 export type WeeklySchedule = {
@@ -200,10 +200,10 @@ function validatedDayOfMonth(n: number) {
 }
 
 function validatedDayOfWeek(s: string) {
-  if (typeof s !== "string" || !DAYS_OF_WEEK.includes(s)) {
+  if (!DAYS_OF_WEEK.includes(s as DayOfWeek)) {
     throw new Error('Day of week must be a string like "monday".');
   }
-  return s;
+  return s as DayOfWeek;
 }
 
 function validatedHourOfDay(n: number) {