Add an isolate test for runQuery recursion depth (#36187)

GitOrigin-RevId: e75d15acfe7344ff0f0554d0b14fdfee09047bcf

Author: goffrie

crates/isolate/src/test_helpers.rs

@@ -1157,12 +1157,12 @@ impl<RT: Runtime, P: Persistence> UdfTest<RT, P> {
     }
 }
 
-static DEFAULT_CONFIG: LazyLock<UdfTestConfig> = LazyLock::new(|| UdfTestConfig {
+pub static DEFAULT_CONFIG: LazyLock<UdfTestConfig> = LazyLock::new(|| UdfTestConfig {
     isolate_config: IsolateConfig::default(),
     udf_server_version: Version::parse("1000.0.0").unwrap(),
 });
 
-static DEFAULT_MAX_ISOLATE_WORKERS: usize = 2;
+pub static DEFAULT_MAX_ISOLATE_WORKERS: usize = 2;
 
 #[derive(Clone)]
 pub struct UdfTestConfig {

crates/isolate/src/tests/adversarial.rs

@@ -51,6 +51,7 @@ use crate::{
     test_helpers::{
         UdfTest,
         UdfTestConfig,
+        DEFAULT_CONFIG,
     },
     tests::logging::nested_function_udf_test,
     IsolateConfig,
@@ -951,3 +952,23 @@ async fn test_uncatchable_errors_are_uncatchable(rt: TestRuntime) -> anyhow::Res
     })
     .await
 }
+
+#[convex_macro::test_runtime]
+async fn test_subfunction_depth(rt: TestRuntime) -> anyhow::Result<()> {
+    let t = UdfTest::default_with_config(DEFAULT_CONFIG.clone(), 16, rt).await?;
+    let error = t
+        .query_js_error(
+            "adversarial:recursiveSubfunction",
+            assert_obj!("depth" => 9.0),
+        )
+        .await?;
+    assert_contains(&error, "Cross component call depth limit exceeded");
+    let result = t
+        .query(
+            "adversarial:recursiveSubfunction",
+            assert_obj!("depth" => 8.0),
+        )
+        .await?;
+    assert_eq!(result, ConvexValue::Float64(8.0));
+    Ok(())
+}

npm-packages/udf-tests/convex/adversarial.ts

@@ -391,3 +391,18 @@ export const simpleQuery = query(async ({ db }) => {
 export const invokeFunctionDirectly = query(async (ctx) => {
   await (simpleQuery as any)(ctx, {});
 });
+
+export const recursiveSubfunction = query(
+  async (ctx, { depth }: { depth: number }): Promise<number> => {
+    if (depth > 0) {
+      return (
+        1 +
+        (await ctx.runQuery(api.adversarial.recursiveSubfunction, {
+          depth: depth - 1,
+        }))
+      );
+    } else {
+      return 0;
+    }
+  },
+);