fix: Run yarn install --prod in ./release.sh

semantic-release runs 'gem build appmap.gemspec', not 'rake gem:build',
so the customization that was running yarn install --prod during the
rake task wasn't actually getting called when releases were made.

The result was missing node_modules, and the rake tasks that depend on
the NodeJS code were broken.

Author: kgilpin

Rakefile

@@ -18,16 +18,11 @@ namespace 'gem' do
 
   module Bundler
     class GemHelper
-      alias default_build_gem build_gem
-  
       # A handy tip - find the location of any Rake task using `rake -W`.
       # rake -W build
       # ~/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/bundler-2.1.4/lib/bundler/gem_helper.rb:39:in `install'
       def build_gem
-        # Ensure that NPM packages are installed before building.
-        sh('yarn install --prod')
-  
-        default_build_gem
+        raise "Don't use 'rake gem:build' - use 'yarn install --prod && gem build <gemspec>', because that's what ./release.sh does"
       end
     end
   end
@@ -81,7 +76,12 @@ namespace :build do
   namespace :base do
     RUBY_VERSIONS.each do |ruby_version|
       desc ruby_version
-      task ruby_version => ["gem:build"] do
+      task ruby_version do
+        run_system = ->(cmd) { system(cmd) or raise "Command failed: #{cmd}" }
+
+        run_system.call 'mkdir -p pkg'
+        run_system.call 'yarn install --prod'
+        run_system.call "gem build appmap.gemspec --output pkg/appmap-#{GEM_VERSION}.gem"
         build_base_image(ruby_version)
       end.tap do |t|
         desc "Build all images"

release.sh

@@ -12,5 +12,6 @@ else
     echo "No GEM_ALTERNATIVE_NAME is provided, releasing gem with default name ('appmap')"
 fi
 
-set -x
+set -ex
+yarn install --prod
 exec semantic-release $RELEASE_FLAGS