update

Author: buenaflor

dart/lib/src/load_dart_debug_images_integration.dart

@@ -4,35 +4,48 @@ import 'debug_image_extractor.dart';
 class LoadDartDebugImagesIntegration extends Integration<SentryOptions> {
   @override
   void call(Hub hub, SentryOptions options) {
-    options.addEventProcessor(
-        _LoadImageIntegrationEventProcessor(DebugImageExtractor(options)));
+    options.addEventProcessor(_LoadImageIntegrationEventProcessor(
+        DebugImageExtractor(options), options));
     options.sdk.addIntegration('loadDartImageIntegration');
   }
 }
 
 const hintRawStackTraceKey = 'raw_stacktrace';
 
 class _LoadImageIntegrationEventProcessor implements EventProcessor {
-  _LoadImageIntegrationEventProcessor(this._debugImageExtractor);
+  _LoadImageIntegrationEventProcessor(this._debugImageExtractor, this._options);
+
+  final SentryOptions _options;
 
   final DebugImageExtractor _debugImageExtractor;
 
   @override
   Future<SentryEvent?> apply(SentryEvent event, Hint hint) async {
     final stackTrace = hint.get(hintRawStackTraceKey) as String?;
-    if (!event.needsSymbolication() || stackTrace == null) {
+    if (!_options.enableDartSymbolication ||
+        !event.needsSymbolication() ||
+        stackTrace == null) {
       return event;
     }
 
-    final syntheticImage =
-        _debugImageExtractor.extractDebugImageFrom(stackTrace);
+    try {
+      final syntheticImage =
+          _debugImageExtractor.extractDebugImageFrom(stackTrace);
+      if (syntheticImage == null) {
+        return event;
+      }
 
-    print(syntheticImage);
-    if (syntheticImage == null) {
+      return event.copyWith(debugMeta: DebugMeta(images: [syntheticImage]));
+    } catch (e, stackTrace) {
+      _options.logger(
+        SentryLevel.info,
+        "Couldn't add Dart debug image to event. "
+        'The event will still be reported.',
+        exception: e,
+        stackTrace: stackTrace,
+      );
       return event;
     }
-
-    return event.copyWith(debugMeta: DebugMeta(images: [syntheticImage]));
   }
 }
 

dart/test/load_dart_debug_images_integration_test.dart

@@ -28,7 +28,8 @@ void main() {
       );
     });
 
-    test('Event processor does not modify event if symbolication is not needed',
+    test(
+        'Event processor does not add debug image if symbolication is not needed',
         () async {
       final event = _getEvent(needsSymbolication: false);
       final processor = fixture.options.eventProcessors.first;
@@ -37,7 +38,7 @@ void main() {
       expect(resultEvent, equals(event));
     });
 
-    test('Event processor does not modify event if stackTrace is null',
+    test('Event processor does not add debug image if stackTrace is null',
         () async {
       final event = _getEvent();
       final processor = fixture.options.eventProcessors.first;
@@ -46,6 +47,17 @@ void main() {
       expect(resultEvent, equals(event));
     });
 
+    test(
+        'Event processor does not add debug image if enableDartSymbolication is false',
+        () async {
+      fixture.options.enableDartSymbolication = false;
+      final event = _getEvent();
+      final processor = fixture.options.eventProcessors.first;
+      final resultEvent = await processor.apply(event, Hint());
+
+      expect(resultEvent, equals(event));
+    });
+
     test('Event processor adds debug image when symbolication is needed',
         () async {
       final stackTrace = '''