Skip to content

Commit 0aec174

Browse files
committed
remove sentry_timestamp from header
1 parent 8cb6557 commit 0aec174

File tree

2 files changed

+7
-16
lines changed

2 files changed

+7
-16
lines changed

dart/lib/src/transport/http_transport.dart

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@ class HttpTransport implements Transport {
4646
_credentialBuilder = _CredentialBuilder(
4747
_dsn,
4848
_options.sentryClientName,
49-
_options.clock,
5049
);
5150
}
5251

@@ -135,23 +134,18 @@ class HttpTransport implements Transport {
135134
class _CredentialBuilder {
136135
final String _authHeader;
137136

138-
final ClockProvider _clock;
139-
140-
int get timestamp => _clock().millisecondsSinceEpoch;
141-
142-
_CredentialBuilder._(String authHeader, ClockProvider clock)
143-
: _authHeader = authHeader,
144-
_clock = clock;
137+
_CredentialBuilder._(String authHeader)
138+
: _authHeader = authHeader;
145139

146140
factory _CredentialBuilder(
147-
Dsn dsn, String sdkIdentifier, ClockProvider clock) {
141+
Dsn dsn, String sdkIdentifier) {
148142
final authHeader = _buildAuthHeader(
149143
publicKey: dsn.publicKey,
150144
secretKey: dsn.secretKey,
151145
sdkIdentifier: sdkIdentifier,
152146
);
153147

154-
return _CredentialBuilder._(authHeader, clock);
148+
return _CredentialBuilder._(authHeader);
155149
}
156150

157151
static String _buildAuthHeader({
@@ -173,7 +167,7 @@ class _CredentialBuilder {
173167
return headers
174168
..addAll(
175169
<String, String>{
176-
'X-Sentry-Auth': '$_authHeader, sentry_timestamp=$timestamp'
170+
'X-Sentry-Auth': _authHeader
177171
},
178172
);
179173
}

dart/test/test_utils.dart

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,17 +30,14 @@ void testHeaders(
3030
'Content-Type': 'application/x-sentry-envelope',
3131
'X-Sentry-Auth': 'Sentry sentry_version=7, '
3232
'sentry_client=$sdkName/$sdkVersion, '
33-
'sentry_key=public, '
33+
'sentry_key=public'
3434
};
3535

3636
if (withSecret) {
3737
expectedHeaders['X-Sentry-Auth'] =
38-
'${expectedHeaders['X-Sentry-Auth']!}sentry_secret=secret, ';
38+
'${expectedHeaders['X-Sentry-Auth']!}, sentry_secret=secret';
3939
}
4040

41-
expectedHeaders['X-Sentry-Auth'] =
42-
'${expectedHeaders['X-Sentry-Auth']!}sentry_timestamp=${fakeClockProvider().millisecondsSinceEpoch}';
43-
4441
if (withUserAgent) {
4542
expectedHeaders['User-Agent'] = '$sdkName/$sdkVersion';
4643
}

0 commit comments

Comments
 (0)