Skip to content

Commit 10639ce

Browse files
authored
Merge branch 'main' into feat/support-allow-urls-deny-urls
2 parents 99a6f98 + 3a16179 commit 10639ce

File tree

5 files changed

+7
-6
lines changed

5 files changed

+7
-6
lines changed

CHANGELOG.md

+4
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,10 @@
3838
- [changelog](https://github.com/getsentry/sentry-cocoa/blob/main/CHANGELOG.md#8360)
3939
- [diff](https://github.com/getsentry/sentry-cocoa/compare/8.35.1...8.36.0)
4040

41+
### Fixes
42+
43+
- Only access renderObject if `hasSize` is true ([#2263](https://github.com/getsentry/sentry-dart/pull/2263))
44+
4145
## 8.8.0
4246

4347
### Features

dart/lib/src/transport/spotlight_http_transport.dart

-4
Original file line numberDiff line numberDiff line change
@@ -38,10 +38,6 @@ class SpotlightHttpTransport extends Transport {
3838
Future<void> _sendToSpotlight(SentryEnvelope envelope) async {
3939
envelope.header.sentAt = _options.clock();
4040

41-
// Screenshots do not work currently https://github.com/getsentry/spotlight/issues/274
42-
envelope.items
43-
.removeWhere((element) => element.header.contentType == 'image/png');
44-
4541
final spotlightRequest = await _requestHandler.createRequest(envelope);
4642

4743
final response = await _options.httpClient

flutter/ios/Classes/SentryFlutterPluginApple.swift

+1-1
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,7 @@ public class SentryFlutterPluginApple: NSObject, FlutterPlugin {
182182
case "nativeCrash":
183183
crash()
184184

185-
case "sendReplayForEvent":
185+
case "captureReplay":
186186
#if canImport(UIKit) && !SENTRY_NO_UIKIT && (os(iOS) || os(tvOS))
187187
PrivateSentrySDKOnly.captureReplay()
188188
result(PrivateSentrySDKOnly.getReplayId())

flutter/lib/src/view_hierarchy/sentry_tree_walker.dart

+1-1
Original file line numberDiff line numberDiff line change
@@ -255,7 +255,7 @@ class _TreeWalker {
255255
double? alpha;
256256

257257
final renderObject = element.renderObject;
258-
if (renderObject is RenderBox) {
258+
if (renderObject is RenderBox && renderObject.hasSize) {
259259
final offset = renderObject.localToGlobal(Offset.zero);
260260
if (offset.dx > 0) {
261261
x = offset.dx;

flutter/test/event_processor/url_filter/web_url_filter_event_processor_test.dart

+1
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import 'package:sentry_flutter/src/event_processor/url_filter/url_filter_event_p
88
// can be tested on command line with
99
// `flutter test --platform=chrome test/event_processor/url_filter/web_url_filter_event_processor_test.dart`
1010
// The URL looks something like this: http://localhost:58551/event_processor/url_filter/web_url_filter_event_processor_test.html
11+
1112
void main() {
1213
group(UrlFilterEventProcessor, () {
1314
late Fixture fixture;

0 commit comments

Comments
 (0)