Enha: polish the CI for Dart and Flutter (#196)

Author: marandaneto

.github/workflows/dart.yml

@@ -35,11 +35,34 @@ jobs:
           with:
             release-channel: ${{ matrix.sdk }}
         - uses: actions/checkout@v2
-        - run: pub get
+        # consider -p "chrome,vm" and --coverage=coverage
         - name: Test (VM and browser)
-          run: pub run test test
-        - run: dartanalyzer --fatal-warnings ./
-        - run: dartfmt -n --set-exit-if-changed ./
+          run: |
+            pub get
+            pub run test --coverage=coverage
+            pub run coverage:format_coverage --lcov --in=coverage --out=coverage/lcov.info --packages=.packages --report-on=lib
+
+        - uses: codecov/codecov-action@v1
+          if: runner.os == 'Linux'
+          with:
+            name: sentry
+            file: ./dart/coverage/lcov.info
+
+  analyze:
+    runs-on: ubuntu-latest
+    defaults:
+      run:
+        working-directory: ./dart
+    steps:
+      - uses: cedx/setup-dart@v2
+        with:
+          release-channel: stable
+      - uses: actions/checkout@v2
+      - run: |
+          pub get
+          dartanalyzer --fatal-warnings ./
+          dartfmt -n --set-exit-if-changed ./
+
   package-analysis:
     runs-on: ubuntu-latest
     steps:

.github/workflows/flutter.yml

@@ -28,23 +28,36 @@ jobs:
             target: web
     steps:
         - uses: actions/checkout@v2
+
         - uses: actions/setup-java@v1
           with:
               java-version: '8'
+
         - uses: subosito/flutter-action@v1
           with:
             channel: ${{ matrix.channel }}
+
         - name: enable web
           if: matrix.target == 'web'
           run: flutter config --enable-web
+
         # https://github.com/flutter/flutter/issues/59522#issuecomment-646208247
         - name: Fix iOS build bug
           if: matrix.target == 'ios'
           run: rm flutter/example/ios/Podfile
+
         - name: Test
           run: |
             cd flutter
-            flutter test
+            flutter pub get
+            flutter test --coverage test
+
+        - uses: codecov/codecov-action@v1
+          if: runner.os == 'Linux'
+          with:
+            name: sentry_flutter
+            file: ./flutter/coverage/lcov.info
+
         - name: Build ${{ matrix.target }}
           env:
             SENTRY_AUTH_TOKEN: ${{ secrets.SENTRY_AUTH_TOKEN }}
@@ -56,12 +69,33 @@ jobs:
             flutter build ios --release --no-codesign
             ;;
             android)
-            flutter build appbundle
+            flutter build appbundle --release
             ;;
             web)
             flutter build web
             ;;
             esac
+
+  format:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - uses: subosito/flutter-action@v1
+      - run: |
+          cd flutter
+          flutter pub get
+          flutter format --set-exit-if-changed .
+
+  analyze:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - uses: subosito/flutter-action@v1
+      - run: |
+          cd flutter
+          flutter pub get
+          flutter analyze
+
   package-analysis:
     runs-on: ubuntu-latest
     steps:
@@ -77,29 +111,32 @@ jobs:
           TOTAL_MAX: ${{ steps.analysis.outputs.total_max }}
         run: |
           PERCENTAGE=$(( $TOTAL * 100 / $TOTAL_MAX ))
-          if (( $PERCENTAGE < 90 ))
+          if (( $PERCENTAGE < 100 ))
           then
             echo Score too low!
             exit 1
           fi
+
   pod-lint:
     runs-on: macos-latest
     steps:
       - uses: actions/checkout@v2
       # https://github.com/CocoaPods/CocoaPods/issues/5275#issuecomment-315461879
       - run: pod lib lint flutter/ios/sentry_flutter.podspec --skip-import-validation --allow-warnings
+
   swift-lint:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
-      - uses: norio-nomura/[email protected]
+      - uses: norio-nomura/[email protected]
+
   ktlint:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
-      - run: brew install ktlint
-      - name: run ktlint
-        run: ktlint --reporter=checkstyle,output=build/ktlint-report.xml || true
-      - uses: yutailang0119/action-ktlint@v1.0.0
+      - run: |
+          brew install ktlint
+          ktlint --reporter=checkstyle,output=build/ktlint-report.xml || true
+      - uses: yutailang0119/action-ktlint@v1
         with:
           xml_path: build/ktlint-report.xml

.gitignore

@@ -21,3 +21,4 @@ build/
 dart/coverage/*
 pubspec.lock
 Podfile.lock
+flutter/coverage/*

dart/pubspec.yaml

@@ -3,7 +3,7 @@ version: 4.0.0-alpha.3
 description: >
   A crash reporting library for Dart that sends crash reports to Sentry.io.
   This library supports Dart VM and Web. For Flutter consider sentry_flutter instead.
-homepage: https://github.com/getsentry/sentry-dart
+homepage: https://docs.sentry.io/platforms/dart/
 repository: https://github.com/getsentry/sentry-dart
 
 environment:
@@ -20,5 +20,5 @@ dev_dependencies:
   pedantic: ^1.9.2
   test: ^1.15.4
   yaml: ^2.2.1
-  test_coverage: ^0.4.1
   collection: ^1.14.13
+  coverage: ^0.14.2

flutter/example/lib/main.dart

@@ -48,7 +48,8 @@ class _MyAppState extends State<MyApp> {
               ),
               RaisedButton(
                 child: const Text('Flutter error : Scaffold.of()'),
-                onPressed: () => Scaffold.of(context).showSnackBar(SnackBar(
+                onPressed: () =>
+                    Scaffold.of(context).showSnackBar(const SnackBar(
                   content: Text(''),
                 )),
               ),
@@ -102,6 +103,7 @@ class _MyAppState extends State<MyApp> {
 class AndroidExample extends StatelessWidget {
   const AndroidExample({Key key}) : super(key: key);
 
+  // ignore: avoid_field_initializers_in_const_classes
   final channel = const MethodChannel('example.flutter.sentry.io');
 
   @override

flutter/lib/src/sentry_flutter.dart

@@ -62,7 +62,7 @@ mixin SentryFlutter {
         ? const String.fromEnvironment('SENTRY_DSN')
         : options.dsn;
 
-    // TODO: load debug images when split symbols are enabled.
+    // TODO(todo): load debug images when split symbols are enabled.
 
     // first step is to install the native integration and set default values,
     // so we are able to capture future errors.

flutter/pubspec.yaml

@@ -6,7 +6,7 @@ repository: https://github.com/getsentry/sentry-dart
 
 environment:
   sdk: ">=2.8.0 <3.0.0"
-  flutter: ^1.17.0
+  flutter: ">=1.17.0 <2.0.0"
 
 dependencies:
   flutter:

flutter/test/load_contexts_integrations_test.dart

@@ -106,8 +106,8 @@ void main() {
       final eventSdk = SdkVersion(
         name: 'sdk1',
         version: '1.0',
-        integrations: ['EventIntegration'],
-        packages: [const SentryPackage('event-package', '2.0')],
+        integrations: const ['EventIntegration'],
+        packages: const [SentryPackage('event-package', '2.0')],
       );
       final e = SentryEvent(sdk: eventSdk);
       final event = await options.eventProcessors.first(e, null);

flutter/test/sentry_flutter_web_test.dart

@@ -7,7 +7,7 @@ import 'package:test/test.dart';
 // import 'sentry_flutter_util_test.dart';
 
 Future<void> main() async {
-  // TODO: validate if flag isWeb will work as intended
+  // TODO(todo): validate if flag isWeb will work as intended
 
   // final options = SentryOptions();
   // await SentryFlutter.init(configurationTester(options, isWeb: true), callback);