Skip to content

Commit 24d43f6

Browse files
committed
remove unused methods
1 parent 6ae5a65 commit 24d43f6

File tree

4 files changed

+3
-51
lines changed

4 files changed

+3
-51
lines changed

flutter/lib/src/integrations/native_app_start_handler.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -295,7 +295,8 @@ class _AppStartInfo {
295295
}
296296

297297
class _TimeSpan {
298-
_TimeSpan({required this.start, required this.end, required this.description});
298+
_TimeSpan(
299+
{required this.start, required this.end, required this.description});
299300

300301
final DateTime start;
301302
final DateTime end;

flutter/lib/src/integrations/native_app_start_integration.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ class NativeAppStartIntegration extends Integration<SentryFlutterOptions> {
1515
final FrameCallbackHandler _frameCallbackHandler;
1616
final NativeAppStartHandler _nativeAppStartHandler;
1717
DateTime? _appStartEnd;
18-
18+
1919
/// This timestamp marks the end of app startup. Either set by calling
2020
// ignore: deprecated_member_use_from_same_package
2121
/// [SentryFlutter.setAppStartEnd]. The [SentryFlutterOptions.autoAppStart]

flutter/lib/src/navigation/time_to_initial_display_tracker.dart

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -45,20 +45,6 @@ class TimeToInitialDisplayTracker {
4545
);
4646
}
4747

48-
Future<void> trackAppStart(ISentrySpan transaction,
49-
{required DateTime startTimestamp,
50-
required DateTime endTimestamp}) async {
51-
await _trackTimeToInitialDisplay(
52-
transaction: transaction,
53-
startTimestamp: startTimestamp,
54-
endTimestamp: endTimestamp,
55-
origin: SentryTraceOrigins.autoUiTimeToDisplay,
56-
);
57-
58-
// Store the end timestamp for potential use by TTFD tracking
59-
_endTimestamp = endTimestamp;
60-
}
61-
6248
Future<void> _trackTimeToInitialDisplay({
6349
required ISentrySpan transaction,
6450
required DateTime startTimestamp,

flutter/test/navigation/time_to_initial_display_tracker_test.dart

Lines changed: 0 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -22,41 +22,6 @@ void main() {
2222
sut.clear();
2323
});
2424

25-
group('app start', () {
26-
test('tracking creates and finishes ttid span with correct measurements',
27-
() async {
28-
final endTimestamp =
29-
fixture.startTimestamp.add(const Duration(milliseconds: 10));
30-
31-
final transaction =
32-
fixture.getTransaction(name: 'root ("/")') as SentryTracer;
33-
await sut.trackAppStart(transaction,
34-
startTimestamp: fixture.startTimestamp, endTimestamp: endTimestamp);
35-
36-
final children = transaction.children;
37-
expect(children, hasLength(1));
38-
39-
final ttidSpan = children.first;
40-
expect(ttidSpan.context.operation,
41-
SentrySpanOperations.uiTimeToInitialDisplay);
42-
expect(ttidSpan.finished, isTrue);
43-
expect(ttidSpan.context.description, 'root ("/") initial display');
44-
expect(ttidSpan.origin, SentryTraceOrigins.autoUiTimeToDisplay);
45-
expect(ttidSpan.startTimestamp, fixture.startTimestamp);
46-
expect(ttidSpan.endTimestamp, endTimestamp);
47-
48-
final ttidMeasurement =
49-
transaction.measurements['time_to_initial_display'];
50-
expect(ttidMeasurement, isNotNull);
51-
expect(ttidMeasurement?.unit, DurationSentryMeasurementUnit.milliSecond);
52-
expect(
53-
ttidMeasurement?.value,
54-
ttidSpan.endTimestamp!
55-
.difference(ttidSpan.startTimestamp)
56-
.inMilliseconds);
57-
});
58-
});
59-
6025
group('regular route', () {
6126
test(
6227
'approximation tracking creates and finishes ttid span with correct measurements',

0 commit comments

Comments
 (0)