fix: SentryHttpClient request body capture checks default PII capture setting, same as the DIO integration

Author: vaind

CHANGELOG.md

@@ -9,6 +9,7 @@
 ### Changes
 
 - Remove experimental `SentryResponse` fields: `url`, `body`, `redirected`, `status` ([#1095](https://github.com/getsentry/sentry-dart/pull/1095))
+- `SentryHttpClient` request body capture checks default PII capture setting, same as the DIO integration ([#1095](https://github.com/getsentry/sentry-dart/pull/1095))
 
 ### Dependencies
 

dart/lib/src/http_client/failed_request_client.dart

@@ -167,8 +167,7 @@ class FailedRequestClient extends BaseClient {
       url: urlWithoutQuery,
       queryString: query,
       cookies: sendDefaultPii ? request.headers['Cookie'] : null,
-      // TODO FIXME - this should check [sendDefaultPii], same as DIO integration.
-      data: _getDataFromRequest(request),
+      data: sendDefaultPii ? _getDataFromRequest(request) : null,
       // ignore: deprecated_member_use_from_same_package
       other: {
         'content_length': request.contentLength.toString(),

dart/test/http_client/failed_request_client_test.dart

@@ -170,8 +170,10 @@ void main() {
 
       final event = fixture.transport.events.first;
       expect(fixture.transport.calls, 1);
+      expect(event.request, isNotNull);
       expect(event.request?.headers.isEmpty, true);
       expect(event.request?.cookies, isNull);
+      expect(event.request?.data, isNull);
       expect(event.contexts.response, isNull);
     });
 
@@ -187,8 +189,10 @@ void main() {
 
       final event = fixture.transport.events.first;
       expect(fixture.transport.calls, 1);
+      expect(event.request, isNotNull);
       expect(event.request?.headers.isEmpty, true);
       expect(event.request?.cookies, isNull);
+      expect(event.request?.data, isNull);
       expect(event.contexts.response, isNotNull);
       expect(event.contexts.response?.headers.isEmpty, true);
     });