Skip to content

Commit 408bdab

Browse files
authored
Fix formatting and analyze ci issues (#1733)
* Fix analysis * Update readme * run format
1 parent 8609bd8 commit 408bdab

File tree

5 files changed

+22
-20
lines changed

5 files changed

+22
-20
lines changed

drift/README.md

+9-1
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,14 @@
88
Sentry integration for `drift` package
99
===========
1010

11+
| package | build | pub | likes | popularity | pub points |
12+
|-------------|-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|------------------------------------------------------------------------------------------------------|------------------------------------------------------------------------------------------------------|----------------------------------------------------------------------------------------------------------------| ------- |
13+
| sentry_drift | [![build](https://github.com/getsentry/sentry-dart/workflows/sentry-drift/badge.svg?branch=main)](https://github.com/getsentry/sentry-dart/actions?query=workflow%3Asentry-drift) | [![pub package](https://img.shields.io/pub/v/sentry_drift.svg)](https://pub.dev/packages/sentry_drift) | [![likes](https://img.shields.io/pub/likes/sentry_drift)](https://pub.dev/packages/sentry_drift/score) | [![popularity](https://img.shields.io/pub/popularity/sentry_drift)](https://pub.dev/packages/sentry_drift/score) | [![pub points](https://img.shields.io/pub/points/sentry_drift)](https://pub.dev/packages/sentry_drift/score)
14+
15+
Integration for the [`drift`](https://pub.dev/packages/drift) package.
16+
17+
#### Usage
18+
1119
- Sign up for a Sentry.io account and get a DSN at https://sentry.io.
1220

1321
- Follow the installing instructions on [pub.dev](https://pub.dev/packages/sentry/install).
@@ -22,7 +30,7 @@ import 'package:drift/native.dart';
2230
import 'package:sentry/sentry.dart';
2331
import 'package:sentry_drift/sentry_drift.dart';
2432
25-
import '../test/test_database.dart';
33+
import 'your_database.dart';
2634
2735
Future<void> main() async {
2836
// ATTENTION: Change the DSN below with your own to see the events in Sentry. Get one at sentry.io

drift/analysis_options.yaml

-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ analyzer:
1717
deprecated_member_use_from_same_package: warning
1818
# ignore sentry/path on pubspec as we change it on deployment
1919
invalid_dependency: ignore
20-
unnecessary_import: ignore
2120
exclude:
2221
- example/**
2322
- test/mocks/mocks.mocks.dart

drift/lib/src/sentry_query_executor.dart

-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import 'dart:async';
22

3-
import 'package:drift/backends.dart';
43
import 'package:drift/drift.dart';
54
import 'package:meta/meta.dart';
65
import 'package:sentry/sentry.dart';

flutter/lib/src/event_processor/flutter_enricher_event_processor.dart

+3-4
Original file line numberDiff line numberDiff line change
@@ -139,16 +139,15 @@ class FlutterEnricherEventProcessor implements EventProcessor {
139139
return <String, String>{
140140
'has_render_view': hasRenderView.toString(),
141141
if (tempDebugBrightnessOverride != null)
142-
'debug_brightness_override': describeEnum(tempDebugBrightnessOverride),
142+
'debug_brightness_override': tempDebugBrightnessOverride.name,
143143
if (debugPlatformOverride != null)
144-
'debug_default_target_platform_override':
145-
describeEnum(debugPlatformOverride),
144+
'debug_default_target_platform_override': debugPlatformOverride.name,
146145
if (initialLifecycleState != null && initialLifecycleState.isNotEmpty)
147146
'initial_lifecycle_state': initialLifecycleState,
148147
if (defaultRouteName != null && defaultRouteName.isNotEmpty)
149148
'default_route_name': defaultRouteName,
150149
if (currentLifecycle != null)
151-
'current_lifecycle_state': describeEnum(currentLifecycle),
150+
'current_lifecycle_state': currentLifecycle.name,
152151
// Seems to always return false.
153152
// Also always fails in tests.
154153
// See https://github.com/flutter/flutter/issues/83919

flutter/lib/src/native/cocoa/binding.dart

+10-13
Original file line numberDiff line numberDiff line change
@@ -37603,8 +37603,7 @@ class ObjCBlock_bool_ObjCObject_ffiUnsignedLong_bool extends _ObjCBlockBase {
3760337603
ObjCBlock_bool_ObjCObject_ffiUnsignedLong_bool.fromFunctionPointer(
3760437604
SentryCocoa lib,
3760537605
ffi.Pointer<
37606-
ffi
37607-
.NativeFunction<
37606+
ffi.NativeFunction<
3760837607
ffi.Bool Function(ffi.Pointer<ObjCObject> arg0,
3760937608
ffi.UnsignedLong arg1, ffi.Pointer<ffi.Bool> arg2)>>
3761037609
ptr)
@@ -42032,17 +42031,15 @@ class ObjCBlock_bool_ObjCObject_bool extends _ObjCBlockBase {
4203242031
ffi.Pointer<ffi.Bool> arg1)>>
4203342032
ptr)
4203442033
: this._(
42035-
lib
42036-
._newBlock1(
42037-
_cFuncTrampoline ??= ffi.Pointer.fromFunction<
42038-
ffi.Bool Function(
42039-
ffi.Pointer<_ObjCBlock> block,
42040-
ffi.Pointer<ObjCObject> arg0,
42041-
ffi.Pointer<ffi.Bool> arg1)>(
42042-
_ObjCBlock_bool_ObjCObject_bool_fnPtrTrampoline,
42043-
false)
42044-
.cast(),
42045-
ptr.cast()),
42034+
lib._newBlock1(
42035+
_cFuncTrampoline ??= ffi.Pointer.fromFunction<
42036+
ffi.Bool Function(
42037+
ffi.Pointer<_ObjCBlock> block,
42038+
ffi.Pointer<ObjCObject> arg0,
42039+
ffi.Pointer<ffi.Bool> arg1)>(
42040+
_ObjCBlock_bool_ObjCObject_bool_fnPtrTrampoline, false)
42041+
.cast(),
42042+
ptr.cast()),
4204642043
lib);
4204742044
static ffi.Pointer<ffi.Void>? _cFuncTrampoline;
4204842045

0 commit comments

Comments
 (0)