Skip to content

Commit 4922ee6

Browse files
committed
disable integration test
1 parent 8c69c94 commit 4922ee6

File tree

5 files changed

+47
-41
lines changed

5 files changed

+47
-41
lines changed

.github/workflows/flutter_integration_test.yml

+30-28
Original file line numberDiff line numberDiff line change
@@ -54,36 +54,38 @@ jobs:
5454
arch: x86_64
5555
profile: Nexus 6
5656
script: flutter test integration_test/integration_test.dart --verbose
57-
test-ios:
58-
runs-on: macos-latest
59-
timeout-minutes: 30
60-
defaults:
61-
run:
62-
working-directory: ./flutter/example
63-
strategy:
64-
fail-fast: false
65-
matrix:
66-
# 'beta' is flaky because of https://github.com/flutter/flutter/issues/124340
67-
sdk: ['stable']
68-
steps:
69-
- name: checkout
70-
uses: actions/checkout@v3
7157

72-
- uses: subosito/flutter-action@48cafc24713cca54bbe03cdc3a423187d413aafa # [email protected]
73-
with:
74-
channel: ${{ matrix.sdk }}
58+
# Enable after fixing https://github.com/getsentry/sentry-dart/issues/1448
59+
# test-ios:
60+
# runs-on: macos-latest
61+
# timeout-minutes: 30
62+
# defaults:
63+
# run:
64+
# working-directory: ./flutter/example
65+
# strategy:
66+
# fail-fast: false
67+
# matrix:
68+
# # 'beta' is flaky because of https://github.com/flutter/flutter/issues/124340
69+
# sdk: ['stable']
70+
# steps:
71+
# - name: checkout
72+
# uses: actions/checkout@v3
7573

76-
- name: flutter upgrade
77-
run: flutter upgrade
74+
# - uses: subosito/flutter-action@48cafc24713cca54bbe03cdc3a423187d413aafa # [email protected]
75+
# with:
76+
# channel: ${{ matrix.sdk }}
7877

79-
- name: flutter pub get
80-
run: flutter pub get
78+
# - name: flutter upgrade
79+
# run: flutter upgrade
8180

82-
- name: launch ios emulator
83-
uses: futureware-tech/simulator-action@ee05c113b79f056b47f354d7b313555f5491e158 #pin@v2
84-
with:
85-
model: 'iPhone 14'
86-
os_version: '16.2'
81+
# - name: flutter pub get
82+
# run: flutter pub get
83+
84+
# - name: launch ios emulator
85+
# uses: futureware-tech/simulator-action@ee05c113b79f056b47f354d7b313555f5491e158 #pin@v2
86+
# with:
87+
# model: 'iPhone 14'
88+
# os_version: '16.2'
8789

88-
- name: run ios integration test
89-
run: flutter test integration_test/integration_test.dart --verbose
90+
# - name: run ios integration test
91+
# run: flutter test integration_test/integration_test.dart --verbose

dart/lib/src/protocol/sentry_event.dart

+6-4
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,9 @@ class SentryEvent with SentryEventLike<SentryEvent> {
1313
DateTime? timestamp,
1414
Map<String, String>? modules,
1515
Map<String, String>? tags,
16-
@Deprecated('Additional Data is deprecated in favor of structured [Contexts] and should be avoided when possible')
17-
Map<String, dynamic>? extra,
16+
@Deprecated(
17+
'Additional Data is deprecated in favor of structured [Contexts] and should be avoided when possible')
18+
Map<String, dynamic>? extra,
1819
List<String>? fingerprint,
1920
List<Breadcrumb>? breadcrumbs,
2021
List<SentryException>? exceptions,
@@ -205,8 +206,9 @@ class SentryEvent with SentryEventLike<SentryEvent> {
205206
SentryLevel? level,
206207
String? culprit,
207208
Map<String, String>? tags,
208-
@Deprecated('Additional Data is deprecated in favor of structured [Contexts] and should be avoided when possible')
209-
Map<String, dynamic>? extra,
209+
@Deprecated(
210+
'Additional Data is deprecated in favor of structured [Contexts] and should be avoided when possible')
211+
Map<String, dynamic>? extra,
210212
List<String>? fingerprint,
211213
SentryUser? user,
212214
Contexts? contexts,

dart/lib/src/protocol/sentry_request.dart

+3-3
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ class SentryRequest {
7272
Map<String, String>? headers,
7373
Map<String, String>? env,
7474
@Deprecated('Will be removed in v8. Use [data] instead')
75-
Map<String, String>? other,
75+
Map<String, String>? other,
7676
}) : _data = data,
7777
_headers = headers != null ? Map.from(headers) : null,
7878
// Look for a 'Set-Cookie' header (case insensitive) if not given.
@@ -91,7 +91,7 @@ class SentryRequest {
9191
Map<String, String>? headers,
9292
Map<String, String>? env,
9393
@Deprecated('Will be removed in v8. Use [data] instead')
94-
Map<String, String>? other,
94+
Map<String, String>? other,
9595
}) {
9696
return SentryRequest(
9797
url: uri.toString(),
@@ -149,7 +149,7 @@ class SentryRequest {
149149
Map<String, String>? headers,
150150
Map<String, String>? env,
151151
@Deprecated('Will be removed in v8. Use [data] instead')
152-
Map<String, String>? other,
152+
Map<String, String>? other,
153153
bool removeCookies = false,
154154
}) =>
155155
SentryRequest(

dart/lib/src/protocol/sentry_transaction.dart

+6-4
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,9 @@ class SentryTransaction extends SentryEvent {
2626
String? transaction,
2727
dynamic throwable,
2828
Map<String, String>? tags,
29-
@Deprecated('Additional Data is deprecated in favor of structured [Contexts] and should be avoided when possible')
30-
Map<String, dynamic>? extra,
29+
@Deprecated(
30+
'Additional Data is deprecated in favor of structured [Contexts] and should be avoided when possible')
31+
Map<String, dynamic>? extra,
3132
SentryUser? user,
3233
Contexts? contexts,
3334
List<Breadcrumb>? breadcrumbs,
@@ -118,8 +119,9 @@ class SentryTransaction extends SentryEvent {
118119
SentryLevel? level,
119120
String? culprit,
120121
Map<String, String>? tags,
121-
@Deprecated('Additional Data is deprecated in favor of structured [Contexts] and should be avoided when possible')
122-
Map<String, dynamic>? extra,
122+
@Deprecated(
123+
'Additional Data is deprecated in favor of structured [Contexts] and should be avoided when possible')
124+
Map<String, dynamic>? extra,
123125
List<String>? fingerprint,
124126
SentryUser? user,
125127
Contexts? contexts,

dart/lib/src/protocol/sentry_user.dart

+2-2
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ class SentryUser {
4343
this.name,
4444
Map<String, dynamic>? data,
4545
@Deprecated('Will be removed in v8. Use [data] instead')
46-
Map<String, dynamic>? extras,
46+
Map<String, dynamic>? extras,
4747
}) : assert(
4848
id != null ||
4949
username != null ||
@@ -145,7 +145,7 @@ class SentryUser {
145145
String? ipAddress,
146146
String? segment,
147147
@Deprecated('Will be removed in v8. Use [data] instead')
148-
Map<String, dynamic>? extras,
148+
Map<String, dynamic>? extras,
149149
String? name,
150150
SentryGeo? geo,
151151
Map<String, dynamic>? data,

0 commit comments

Comments
 (0)