remove sub-seconds from the timestamp format (#2)

Author: yjbanov

CHANGELOG.md

@@ -1,5 +1,13 @@
 # package:sentry changelog
 
+## 0.0.5
+
+- remove sub-seconds from the timestamp
+
+## 0.0.4
+
+- parse and report async gaps in stack traces
+
 ## 0.0.3
 
 - environment attributes

lib/sentry.dart

@@ -164,7 +164,7 @@ class SentryClient {
     Map<String, dynamic> json = <String, dynamic>{
       'project': projectId,
       'event_id': _uuidGenerator(),
-      'timestamp': _clock.now().toIso8601String(),
+      'timestamp': formatDateAsIso8601WithSecondPrecision(_clock.now()),
       'logger': defaultLoggerName,
     };
 

lib/src/utils.dart

@@ -20,3 +20,11 @@ void mergeAttributes(Map<String, dynamic> attributes,
     }
   });
 }
+
+String formatDateAsIso8601WithSecondPrecision(DateTime date) {
+  String iso = date.toIso8601String();
+  final millisecondSeparatorIndex = iso.lastIndexOf('.');
+  if (millisecondSeparatorIndex != -1)
+    iso = iso.substring(0, millisecondSeparatorIndex);
+  return iso;
+}

lib/src/version.dart

@@ -9,7 +9,7 @@
 library version;
 
 /// The SDK version reported to Sentry.io in the submitted events.
-const String sdkVersion = '0.0.4';
+const String sdkVersion = '0.0.5';
 
 /// The SDK name reported to Sentry.io in the submitted events.
 const String sdkName = 'dart';

pubspec.yaml

@@ -1,5 +1,5 @@
 name: sentry
-version: 0.0.4
+version: 0.0.5
 description: A pure Dart Sentry.io client.
 author: Yegor Jbanov <[email protected]>
 homepage: https://github.com/yjbanov/sentry

test/sentry_test.dart

@@ -3,8 +3,8 @@
 // found in the LICENSE file.
 
 import 'dart:convert';
-
 import 'dart:io';
+
 import 'package:http/http.dart';
 import 'package:mockito/mockito.dart';
 import 'package:quiver/time.dart';
@@ -27,7 +27,7 @@ void main() {
 
     testCaptureException(bool compressPayload) async {
       final MockClient httpMock = new MockClient();
-      final Clock fakeClock = new Clock.fixed(new DateTime(2017, 1, 2));
+      final Clock fakeClock = new Clock.fixed(new DateTime.utc(2017, 1, 2));
 
       String postUri;
       Map<String, String> headers;
@@ -101,7 +101,7 @@ void main() {
       expect(json, {
         'project': '1',
         'event_id': 'X' * 32,
-        'timestamp': '2017-01-02T00:00:00.000',
+        'timestamp': '2017-01-02T00:00:00',
         'platform': 'dart',
         'exception': [
           {'type': 'ArgumentError', 'value': 'Invalid argument(s): Test error'}

test/utils_test.dart

@@ -36,4 +36,14 @@ void main() {
       });
     });
   });
+
+  group('formatDateAsIso8601WithSecondPrecision', () {
+    test('strips sub-millisecond parts', () {
+      final DateTime testDate =
+          new DateTime.fromMillisecondsSinceEpoch(1502467721598, isUtc: true);
+      expect(testDate.toIso8601String(), '2017-08-11T16:08:41.598Z');
+      expect(formatDateAsIso8601WithSecondPrecision(testDate),
+          '2017-08-11T16:08:41');
+    });
+  });
 }