Skip to content

Commit 5dd824e

Browse files
committed
Add (not all) improvements for pr review
1 parent 4dedf37 commit 5dd824e

File tree

4 files changed

+18
-30
lines changed

4 files changed

+18
-30
lines changed

dart/lib/src/sentry_measurement.dart

+14
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,20 @@ class SentryMeasurement {
3939
value = duration.inMilliseconds,
4040
unit = DurationSentryMeasurementUnit.milliSecond;
4141

42+
/// Duration of the time to initial display in milliseconds
43+
SentryMeasurement.timeToInitialDisplay(Duration duration) :
44+
assert(!duration.isNegative),
45+
name = 'time_to_initial_display',
46+
value = duration.inMilliseconds,
47+
unit = DurationSentryMeasurementUnit.milliSecond;
48+
49+
/// Duration of the time to full display in milliseconds
50+
SentryMeasurement.timeToFullDisplay(Duration duration) :
51+
assert(!duration.isNegative),
52+
name = 'time_to_full_display',
53+
value = duration.inMilliseconds,
54+
unit = DurationSentryMeasurementUnit.milliSecond;
55+
4256
final String name;
4357
final num value;
4458
final SentryMeasurementUnit? unit;

flutter/lib/src/navigation/sentry_navigator_observer.dart

+1-1
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,7 @@ class SentryNavigatorObserver extends RouteObserver<PageRoute<dynamic>> {
221221

222222
final arguments = route?.settings.arguments;
223223
await _timeToDisplayTracker?.startTracking(routeName, arguments);
224-
completedDisplayTracking?.complete();
224+
_completedDisplayTracking?.complete();
225225
}
226226
}
227227

flutter/lib/src/navigation/time_to_initial_display_tracker.dart

+3-6
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ import '../integrations/integrations.dart';
77

88
import '../../sentry_flutter.dart';
99
import '../frame_callback_handler.dart';
10-
import '../sentry_flutter_measurement.dart';
1110

1211
@internal
1312
class TimeToInitialDisplayTracker {
@@ -49,10 +48,8 @@ class TimeToInitialDisplayTracker {
4948
ttidSpan.origin = SentryTraceOrigins.autoUiTimeToDisplay;
5049
}
5150

52-
final ttidMeasurement = SentryFlutterMeasurement.timeToInitialDisplay(
53-
Duration(
54-
milliseconds:
55-
endTimestamp.difference(startTimestamp).inMilliseconds));
51+
final ttidMeasurement = SentryMeasurement.timeToInitialDisplay(Duration(
52+
milliseconds: endTimestamp.difference(startTimestamp).inMilliseconds));
5653
transaction.setMeasurement(ttidMeasurement.name, ttidMeasurement.value,
5754
unit: ttidMeasurement.unit);
5855
await ttidSpan.finish(endTimestamp: endTimestamp);
@@ -68,7 +65,7 @@ class TimeToInitialDisplayTracker {
6865
ttidSpan.origin = SentryTraceOrigins.autoUiTimeToDisplay;
6966

7067
final ttidMeasurement =
71-
SentryFlutterMeasurement.timeToInitialDisplay(appStartInfo.duration);
68+
SentryMeasurement.timeToInitialDisplay(appStartInfo.duration);
7269
transaction.setMeasurement(ttidMeasurement.name, ttidMeasurement.value,
7370
unit: ttidMeasurement.unit);
7471

flutter/lib/src/sentry_flutter_measurement.dart

-23
This file was deleted.

0 commit comments

Comments
 (0)