removed useless types

renamed a test

Author: stefanosiano

dart/lib/src/metrics/metric.dart

@@ -43,14 +43,14 @@ abstract class Metric {
   /// [bucketKey] is the key of the metric bucket that will be sent to Sentry,
   ///  and it's appended at the end of the encoded metric.
   String encodeToStatsd(int bucketKey) {
-    final StringBuffer buffer = StringBuffer();
+    final buffer = StringBuffer();
     buffer.write(_normalizeKey(key));
     buffer.write("@");
 
-    final String sanitizeUnitName = _sanitizeUnit(unit.name);
+    final sanitizeUnitName = _sanitizeUnit(unit.name);
     buffer.write(sanitizeUnitName);
 
-    for (Object value in _serializeValue()) {
+    for (final value in _serializeValue()) {
       buffer.write(":");
       buffer.write(value.toString());
     }
@@ -60,7 +60,7 @@ abstract class Metric {
 
     if (tags.isNotEmpty) {
       buffer.write("|#");
-      String serializedTags = tags.entries
+      final serializedTags = tags.entries
           .map((tag) =>
               '${_normalizeKey(tag.key)}:${_normalizeTagValue(tag.value)}')
           .join(',');
@@ -102,7 +102,7 @@ abstract class Metric {
 
 @internal
 
-/// Metric [MetricType.counter] that track a value that can only be incremented.
+/// Metric [MetricType.counter] that tracks a value that can only be incremented.
 class CounterMetric extends Metric {
   double value;
 

dart/lib/src/metrics/metrics_aggregator.dart

@@ -50,10 +50,9 @@ class MetricsAggregator {
       return;
     }
 
-    final int bucketKey = _getBucketKey(_options.clock());
-    final Map<String, Metric> bucket =
-        _buckets.putIfAbsent(bucketKey, () => {});
-    final Metric metric =
+    final bucketKey = _getBucketKey(_options.clock());
+    final bucket = _buckets.putIfAbsent(bucketKey, () => {});
+    final metric =
         CounterMetric(value: value, key: key, unit: unit, tags: tags);
 
     // Update the existing metric in the bucket.
@@ -90,7 +89,7 @@ class MetricsAggregator {
 
   /// Flush and sends metrics.
   Future<void> _flush() async {
-    final Iterable<int> flushableBucketKeys = _getFlushableBucketKeys();
+    final flushableBucketKeys = _getFlushableBucketKeys();
     if (flushableBucketKeys.isEmpty) {
       _options.logger(SentryLevel.debug, 'Metrics: nothing to flush');
       return;
@@ -100,7 +99,7 @@ class MetricsAggregator {
     int numMetrics = 0;
 
     for (int flushableBucketKey in flushableBucketKeys) {
-      final Map<String, Metric>? bucket = _buckets.remove(flushableBucketKey);
+      final bucket = _buckets.remove(flushableBucketKey);
       if (bucket != null) {
         numMetrics += bucket.length;
         bucketsToFlush[flushableBucketKey] = bucket.values;
@@ -120,11 +119,11 @@ class MetricsAggregator {
   List<int> _getFlushableBucketKeys() {
     // Flushable buckets are all buckets with timestamp lower than the current
     // one (so now - rollupInSeconds), minus a random duration (flushShiftMs).
-    final DateTime maxTimestampToFlush = _options.clock().subtract(Duration(
+    final maxTimestampToFlush = _options.clock().subtract(Duration(
           seconds: _rollupInSeconds,
           milliseconds: _flushShiftMs,
         ));
-    final int maxKeyToFlush = _getBucketKey(maxTimestampToFlush);
+    final maxKeyToFlush = _getBucketKey(maxTimestampToFlush);
 
     // takeWhile works because we use a SplayTreeMap and keys are ordered.
     // toList() is needed because takeWhile is lazy and we want to remove items
@@ -134,7 +133,7 @@ class MetricsAggregator {
 
   /// The timestamp of the bucket, rounded down to the nearest RollupInSeconds.
   int _getBucketKey(DateTime timestamp) {
-    final int seconds = timestamp.millisecondsSinceEpoch ~/ 1000;
+    final seconds = timestamp.millisecondsSinceEpoch ~/ 1000;
     return (seconds ~/ _rollupInSeconds) * _rollupInSeconds;
   }
 

dart/lib/src/sentry_envelope_item.dart

@@ -86,11 +86,11 @@ class SentryEnvelopeItem {
   /// Creates a [SentryEnvelopeItem] which holds several [Metric] data.
   factory SentryEnvelopeItem.fromMetrics(Map<int, Iterable<Metric>> buckets) {
     final cachedItem = _CachedItem(() async {
-      final StringBuffer statsd = StringBuffer();
+      final statsd = StringBuffer();
       // Encode all metrics of a bucket in statsd format, using the bucket key,
       //  which is the timestamp of the bucket.
-      for (MapEntry<int, Iterable<Metric>> bucket in buckets.entries) {
-        final Iterable<String> encodedMetrics =
+      for (final bucket in buckets.entries) {
+        final encodedMetrics =
             bucket.value.map((metric) => metric.encodeToStatsd(bucket.key));
         statsd.write(encodedMetrics.join('\n'));
       }

dart/test/hub_test.dart

@@ -718,7 +718,7 @@ void main() {
           'Metrics are disabled and this \'captureMetrics\' call is a no-op.');
     });
 
-    test('should not capture metrics if enableMetric is false', () async {
+    test('should not capture metrics if hub is closed', () async {
       final hub = fixture.getSut(debug: true);
       await hub.close();