Update

Author: buenaflor

dart/lib/src/sentry_span_operations.dart

@@ -4,5 +4,4 @@ import 'package:meta/meta.dart';
 class SentrySpanOperations {
   static const String uiLoad = 'ui.load';
   static const String uiTimeToInitialDisplay = 'ui.load.initial_display';
-  static const String uiTimeToFullDisplay = 'ui.load.full_display';
 }

dart/lib/src/sentry_tracer.dart

@@ -362,8 +362,7 @@ class SentryTracer extends ISentrySpan {
       Dsn.parse(_hub.options.dsn!).publicKey,
       release: _hub.options.release,
       environment: _hub.options.environment,
-      userId: null,
-      // because of PII not sending it for now
+      userId: null, // because of PII not sending it for now
       userSegment: user?.segment,
       transaction:
           _isHighQualityTransactionName(transactionNameSource) ? name : null,

flutter/lib/src/navigation/sentry_navigator_observer.dart

@@ -86,10 +86,7 @@ class SentryNavigatorObserver extends RouteObserver<PageRoute<dynamic>> {
       _hub.options.sdk.addIntegration('UINavigationTracing');
     }
     _timeToDisplayTracker = timeToDisplayTracker ??
-        TimeToDisplayTracker(
-          // TODO: ttfd flag
-          enableTimeToFullDisplayTracing: false,
-        );
+        TimeToDisplayTracker();
   }
 
   final Hub _hub;
@@ -202,14 +199,15 @@ class SentryNavigatorObserver extends RouteObserver<PageRoute<dynamic>> {
   }
 
   Future<void> _finishTransaction() async {
-    _timeToDisplayTracker?.clear();
-
-    final transaction = _hub.getSpan();
+    final transaction = _transaction;
+    _transaction = null;
     if (transaction == null || transaction.finished) {
       return;
     }
     transaction.status ??= SpanStatus.ok();
     await transaction.finish();
+
+    _timeToDisplayTracker?.clear();
   }
 
   Future<void> _startTransaction(Route<dynamic>? route) async {

flutter/lib/src/navigation/time_to_display_tracker.dart

@@ -14,14 +14,9 @@ class TimeToDisplayTracker {
   final SentryNative? _native;
   final TimeToInitialDisplayTracker _ttidTracker;
 
-  // TODO We can use _hub.options to fetch the ttfd flag
-  final bool _enableTimeToFullDisplayTracing;
-
   TimeToDisplayTracker({
-    required bool enableTimeToFullDisplayTracing,
     TimeToInitialDisplayTracker? ttidTracker,
   })  : _native = SentryFlutter.native,
-        _enableTimeToFullDisplayTracing = enableTimeToFullDisplayTracing,
         _ttidTracker = ttidTracker ?? TimeToInitialDisplayTracker();
 
   Future<void> startTracking(
@@ -36,7 +31,6 @@ class TimeToDisplayTracker {
     if (routeName == null) return;
 
     if (isRootScreen && didFetchAppStart == false) {
-      // Dart cannot infer here that routeName is not nullable
       await _trackAppStartTTD(transaction, routeName, arguments);
     } else {
       await _trackRegularRouteTTD(
@@ -49,38 +43,24 @@ class TimeToDisplayTracker {
   /// This method listens for the completion of the app's start process via
   /// [AppStartTracker], then:
   /// - Starts a transaction with the app start start timestamp
-  /// - Starts TTID and optionally TTFD spans based on the app start start timestamp
+  /// - Starts a TTID span based on the app start start timestamp
   /// - Finishes the TTID span immediately with the app start end timestamp
   ///
   /// We start and immediately finish the TTID span since we cannot mutate the history of spans.
   Future<void> _trackAppStartTTD(
       ISentrySpan transaction, String routeName, Object? arguments) async {
     final appStartInfo = await NativeAppStartIntegration.getAppStartInfo();
     if (appStartInfo == null) return;
-
-    if (_enableTimeToFullDisplayTracing) {
-      // TODO: implement TTFD
-    }
-
     await _ttidTracker.trackAppStart(transaction, appStartInfo, routeName);
   }
 
   /// Starts and finishes Time To Display spans for regular routes meaning routes that are not root.
   Future<void> _trackRegularRouteTTD(ISentrySpan transaction, String routeName,
       Object? arguments, DateTime startTimestamp) async {
-    if (_enableTimeToFullDisplayTracing) {
-      // TODO: implement TTFD
-    }
-
     await _ttidTracker.trackRegularRoute(
         transaction, startTimestamp, routeName);
   }
 
-  @internal
-  Future<void> reportFullyDisplayed() async {
-    // TODO: implement TTFD
-  }
-
   void clear() {
     _ttidTracker.clear();
   }

flutter/test/navigation/sentry_display_widget_test.dart

@@ -86,7 +86,7 @@ void main() {
     expect(tracer.measurements, hasLength(1));
     final measurement = tracer.measurements['time_to_initial_display'];
     expect(measurement, isNotNull);
-    expect(measurement?.value, 1000);
+    expect(measurement?.value, appStartInfo.duration.inMilliseconds);
     expect(measurement?.unit, DurationSentryMeasurementUnit.milliSecond);
   });
 }

flutter/test/navigation/time_to_display_tracker_test.dart

@@ -123,16 +123,12 @@ class Fixture {
   late final ttidTracker =
       TimeToInitialDisplayTracker(frameCallbackHandler: frameCallbackHandler);
 
-  final ttfdAutoFinishAfter = Duration(milliseconds: 500);
-
   ISentrySpan getTransaction({String? name = "Current route"}) {
     return hub.startTransaction(name!, 'ui.load', bindToScope: true);
   }
 
   TimeToDisplayTracker getSut() {
     return TimeToDisplayTracker(
-      // TODO: ttfd flag
-      enableTimeToFullDisplayTracing: false,
       ttidTracker: ttidTracker,
     );
   }

flutter/test/sentry_navigator_observer_test.dart

@@ -877,7 +877,7 @@ class Fixture {
     final timeToInitialDisplayTracker =
         TimeToInitialDisplayTracker(frameCallbackHandler: frameCallbackHandler);
     final timeToDisplayTracker = TimeToDisplayTracker(
-      // TODO: ttfd flag
+      // TODO: ttfd flag via options
       enableTimeToFullDisplayTracing: false,
       ttidTracker: timeToInitialDisplayTracker,
     );