Skip to content

Commit 8613819

Browse files
committed
use path pub
1 parent dec3513 commit 8613819

File tree

2 files changed

+4
-14
lines changed

2 files changed

+4
-14
lines changed

sqflite/lib/src/sentry_database.dart

+3-14
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import 'sentry_database_executor.dart';
66
import 'sentry_sqflite_transaction.dart';
77
import 'version.dart';
88
import 'utils/sentry_database_span_attributes.dart';
9+
import 'package:path/path.dart' as p;
910

1011
/// A [Database] wrapper that adds Sentry support.
1112
///
@@ -56,27 +57,15 @@ class SentryDatabase extends SentryDatabaseExecutor implements Database {
5657
this._database, {
5758
@internal Hub? hub,
5859
}) : _hub = hub ?? HubAdapter(),
59-
dbName = _basenameWithoutExtension(_database.path),
60+
dbName = p.basenameWithoutExtension(_database.path),
6061
super(_database,
61-
hub: hub, dbName: _basenameWithoutExtension(_database.path)) {
62+
hub: hub, dbName: p.basenameWithoutExtension(_database.path)) {
6263
// ignore: invalid_use_of_internal_member
6364
final options = _hub.options;
6465
options.sdk.addIntegration('SentrySqfliteTracing');
6566
options.sdk.addPackage(packageName, sdkVersion);
6667
}
6768

68-
/// Gets the part of path after the last separator, and without any trailing file extension.
69-
static String _basenameWithoutExtension(String filePath) {
70-
final int lastIndex = filePath.lastIndexOf('/');
71-
final int dotIndex = filePath.lastIndexOf('.');
72-
73-
if (dotIndex == -1 || (lastIndex != -1 && dotIndex < lastIndex)) {
74-
return filePath;
75-
}
76-
77-
return filePath.substring(lastIndex + 1, dotIndex);
78-
}
79-
8069
// TODO: check if perf is enabled
8170

8271
@override

sqflite/pubspec.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ dependencies:
1414
sqflite: ^2.0.0
1515
sqflite_common: ^2.0.0
1616
meta: ^1.3.0
17+
path: ^1.8.3
1718

1819
dev_dependencies:
1920
lints: ^2.0.0

0 commit comments

Comments
 (0)