Skip to content

Commit af3d295

Browse files
denrasedenrase
committed
change breadcrumb type and level
1 parent e58a4d8 commit af3d295

5 files changed

+62
-62
lines changed

‎sqflite/lib/src/sentry_batch.dart

+4-4
Original file line numberDiff line numberDiff line change
@@ -79,8 +79,8 @@ class SentryBatch implements Batch {
7979

8080
breadcrumb.data?['status'] = 'internal_error';
8181
breadcrumb = breadcrumb.copyWith(
82-
type: 'error',
83-
level: SentryLevel.error,
82+
type: 'query',
83+
level: SentryLevel.warning,
8484
);
8585

8686
rethrow;
@@ -133,8 +133,8 @@ class SentryBatch implements Batch {
133133

134134
breadcrumb.data?['status'] = 'internal_error';
135135
breadcrumb = breadcrumb.copyWith(
136-
type: 'error',
137-
level: SentryLevel.error,
136+
type: 'query',
137+
level: SentryLevel.warning,
138138
);
139139

140140
rethrow;

‎sqflite/lib/src/sentry_database.dart

+4-4
Original file line numberDiff line numberDiff line change
@@ -99,8 +99,8 @@ class SentryDatabase extends SentryDatabaseExecutor implements Database {
9999
span?.status = SpanStatus.internalError();
100100
breadcrumb.data?['status'] = 'internal_error';
101101
breadcrumb = breadcrumb.copyWith(
102-
type: 'error',
103-
level: SentryLevel.error,
102+
type: 'query',
103+
level: SentryLevel.warning,
104104
);
105105

106106
rethrow;
@@ -183,8 +183,8 @@ class SentryDatabase extends SentryDatabaseExecutor implements Database {
183183
span?.status = SpanStatus.internalError();
184184
breadcrumb.data?['status'] = 'internal_error';
185185
breadcrumb = breadcrumb.copyWith(
186-
type: 'error',
187-
level: SentryLevel.error,
186+
type: 'query',
187+
level: SentryLevel.warning,
188188
);
189189

190190
rethrow;

‎sqflite/lib/src/sentry_database_executor.dart

+24-24
Original file line numberDiff line numberDiff line change
@@ -67,8 +67,8 @@ class SentryDatabaseExecutor implements DatabaseExecutor {
6767
span?.status = SpanStatus.internalError();
6868
breadcrumb.data?['status'] = 'internal_error';
6969
breadcrumb = breadcrumb.copyWith(
70-
type: 'error',
71-
level: SentryLevel.error,
70+
type: 'query',
71+
level: SentryLevel.warning,
7272
);
7373

7474
rethrow;
@@ -110,12 +110,12 @@ class SentryDatabaseExecutor implements DatabaseExecutor {
110110
span?.status = SpanStatus.internalError();
111111
breadcrumb.data?['status'] = 'internal_error';
112112
breadcrumb = breadcrumb.copyWith(
113-
type: 'error',
114-
level: SentryLevel.error,
113+
type: 'query',
114+
level: SentryLevel.warning,
115115
);
116116
breadcrumb = breadcrumb.copyWith(
117-
type: 'error',
118-
level: SentryLevel.error,
117+
type: 'query',
118+
level: SentryLevel.warning,
119119
);
120120

121121
rethrow;
@@ -174,8 +174,8 @@ class SentryDatabaseExecutor implements DatabaseExecutor {
174174
span?.status = SpanStatus.internalError();
175175
breadcrumb.data?['status'] = 'internal_error';
176176
breadcrumb = breadcrumb.copyWith(
177-
type: 'error',
178-
level: SentryLevel.error,
177+
type: 'query',
178+
level: SentryLevel.warning,
179179
);
180180

181181
rethrow;
@@ -253,8 +253,8 @@ class SentryDatabaseExecutor implements DatabaseExecutor {
253253
span?.status = SpanStatus.internalError();
254254
breadcrumb.data?['status'] = 'internal_error';
255255
breadcrumb = breadcrumb.copyWith(
256-
type: 'error',
257-
level: SentryLevel.error,
256+
type: 'query',
257+
level: SentryLevel.warning,
258258
);
259259

260260
rethrow;
@@ -334,8 +334,8 @@ class SentryDatabaseExecutor implements DatabaseExecutor {
334334
span?.status = SpanStatus.internalError();
335335
breadcrumb.data?['status'] = 'internal_error';
336336
breadcrumb = breadcrumb.copyWith(
337-
type: 'error',
338-
level: SentryLevel.error,
337+
type: 'query',
338+
level: SentryLevel.warning,
339339
);
340340

341341
rethrow;
@@ -378,8 +378,8 @@ class SentryDatabaseExecutor implements DatabaseExecutor {
378378
span?.status = SpanStatus.internalError();
379379
breadcrumb.data?['status'] = 'internal_error';
380380
breadcrumb = breadcrumb.copyWith(
381-
type: 'error',
382-
level: SentryLevel.error,
381+
type: 'query',
382+
level: SentryLevel.warning,
383383
);
384384

385385
rethrow;
@@ -422,8 +422,8 @@ class SentryDatabaseExecutor implements DatabaseExecutor {
422422
span?.status = SpanStatus.internalError();
423423
breadcrumb.data?['status'] = 'internal_error';
424424
breadcrumb = breadcrumb.copyWith(
425-
type: 'error',
426-
level: SentryLevel.error,
425+
type: 'query',
426+
level: SentryLevel.warning,
427427
);
428428

429429
rethrow;
@@ -470,8 +470,8 @@ class SentryDatabaseExecutor implements DatabaseExecutor {
470470
span?.status = SpanStatus.internalError();
471471
breadcrumb.data?['status'] = 'internal_error';
472472
breadcrumb = breadcrumb.copyWith(
473-
type: 'error',
474-
level: SentryLevel.error,
473+
type: 'query',
474+
level: SentryLevel.warning,
475475
);
476476

477477
rethrow;
@@ -523,8 +523,8 @@ class SentryDatabaseExecutor implements DatabaseExecutor {
523523
span?.status = SpanStatus.internalError();
524524
breadcrumb.data?['status'] = 'internal_error';
525525
breadcrumb = breadcrumb.copyWith(
526-
type: 'error',
527-
level: SentryLevel.error,
526+
type: 'query',
527+
level: SentryLevel.warning,
528528
);
529529

530530
rethrow;
@@ -567,8 +567,8 @@ class SentryDatabaseExecutor implements DatabaseExecutor {
567567
span?.status = SpanStatus.internalError();
568568
breadcrumb.data?['status'] = 'internal_error';
569569
breadcrumb = breadcrumb.copyWith(
570-
type: 'error',
571-
level: SentryLevel.error,
570+
type: 'query',
571+
level: SentryLevel.warning,
572572
);
573573

574574
rethrow;
@@ -630,8 +630,8 @@ class SentryDatabaseExecutor implements DatabaseExecutor {
630630
span?.status = SpanStatus.internalError();
631631
breadcrumb.data?['status'] = 'internal_error';
632632
breadcrumb = breadcrumb.copyWith(
633-
type: 'error',
634-
level: SentryLevel.error,
633+
type: 'query',
634+
level: SentryLevel.warning,
635635
);
636636

637637
rethrow;

‎sqflite/test/sentry_batch_test.dart

+4-4
Original file line numberDiff line numberDiff line change
@@ -615,8 +615,8 @@ SELECT * FROM Product''';
615615

616616
final breadcrumb = fixture.hub.scope.breadcrumbs.last;
617617
expect(breadcrumb.data?['status'], 'internal_error');
618-
expect(breadcrumb.type, 'error');
619-
expect(breadcrumb.level, SentryLevel.error);
618+
expect(breadcrumb.type, 'query');
619+
expect(breadcrumb.level, SentryLevel.warning);
620620
});
621621

622622
test('apply sets span to internal error if its thrown', () async {
@@ -646,8 +646,8 @@ SELECT * FROM Product''';
646646

647647
final breadcrumb = fixture.hub.scope.breadcrumbs.last;
648648
expect(breadcrumb.data?['status'], 'internal_error');
649-
expect(breadcrumb.type, 'error');
650-
expect(breadcrumb.level, SentryLevel.error);
649+
expect(breadcrumb.type, 'query');
650+
expect(breadcrumb.level, SentryLevel.warning);
651651
});
652652
});
653653
}

‎sqflite/test/sentry_database_test.dart

+26-26
Original file line numberDiff line numberDiff line change
@@ -242,8 +242,8 @@ void main() {
242242

243243
final breadcrumb = fixture.hub.scope.breadcrumbs.first;
244244
expect(breadcrumb.data?['status'], 'internal_error');
245-
expect(breadcrumb.type, 'error');
246-
expect(breadcrumb.level, SentryLevel.error);
245+
expect(breadcrumb.type, 'query');
246+
expect(breadcrumb.level, SentryLevel.warning);
247247
});
248248

249249
test('transaction sets span to internal error', () async {
@@ -281,8 +281,8 @@ void main() {
281281

282282
final breadcrumb = fixture.hub.scope.breadcrumbs.first;
283283
expect(breadcrumb.data?['status'], 'internal_error');
284-
expect(breadcrumb.type, 'error');
285-
expect(breadcrumb.level, SentryLevel.error);
284+
expect(breadcrumb.type, 'query');
285+
expect(breadcrumb.level, SentryLevel.warning);
286286
});
287287
});
288288

@@ -1007,8 +1007,8 @@ void main() {
10071007

10081008
final breadcrumb = fixture.hub.scope.breadcrumbs.first;
10091009
expect(breadcrumb.data?['status'], 'internal_error');
1010-
expect(breadcrumb.type, 'error');
1011-
expect(breadcrumb.level, SentryLevel.error);
1010+
expect(breadcrumb.type, 'query');
1011+
expect(breadcrumb.level, SentryLevel.warning);
10121012
});
10131013

10141014
test('execute sets breadcrumb to internal error', () async {
@@ -1023,8 +1023,8 @@ void main() {
10231023

10241024
final breadcrumb = fixture.hub.scope.breadcrumbs.first;
10251025
expect(breadcrumb.data?['status'], 'internal_error');
1026-
expect(breadcrumb.type, 'error');
1027-
expect(breadcrumb.level, SentryLevel.error);
1026+
expect(breadcrumb.type, 'query');
1027+
expect(breadcrumb.level, SentryLevel.warning);
10281028
});
10291029

10301030
test('insert sets breadcrumb to internal error', () async {
@@ -1040,8 +1040,8 @@ void main() {
10401040

10411041
final breadcrumb = fixture.hub.scope.breadcrumbs.first;
10421042
expect(breadcrumb.data?['status'], 'internal_error');
1043-
expect(breadcrumb.type, 'error');
1044-
expect(breadcrumb.level, SentryLevel.error);
1043+
expect(breadcrumb.type, 'query');
1044+
expect(breadcrumb.level, SentryLevel.warning);
10451045
});
10461046

10471047
test('query sets breadcrumb to internal error', () async {
@@ -1056,8 +1056,8 @@ void main() {
10561056

10571057
final breadcrumb = fixture.hub.scope.breadcrumbs.first;
10581058
expect(breadcrumb.data?['status'], 'internal_error');
1059-
expect(breadcrumb.type, 'error');
1060-
expect(breadcrumb.level, SentryLevel.error);
1059+
expect(breadcrumb.type, 'query');
1060+
expect(breadcrumb.level, SentryLevel.warning);
10611061
});
10621062

10631063
test('query cursor sets breadcrumb to internal error', () async {
@@ -1072,8 +1072,8 @@ void main() {
10721072

10731073
final breadcrumb = fixture.hub.scope.breadcrumbs.first;
10741074
expect(breadcrumb.data?['status'], 'internal_error');
1075-
expect(breadcrumb.type, 'error');
1076-
expect(breadcrumb.level, SentryLevel.error);
1075+
expect(breadcrumb.type, 'query');
1076+
expect(breadcrumb.level, SentryLevel.warning);
10771077
});
10781078

10791079
test('raw delete sets breadcrumb to internal error', () async {
@@ -1088,8 +1088,8 @@ void main() {
10881088

10891089
final breadcrumb = fixture.hub.scope.breadcrumbs.first;
10901090
expect(breadcrumb.data?['status'], 'internal_error');
1091-
expect(breadcrumb.type, 'error');
1092-
expect(breadcrumb.level, SentryLevel.error);
1091+
expect(breadcrumb.type, 'query');
1092+
expect(breadcrumb.level, SentryLevel.warning);
10931093
});
10941094

10951095
test('raw insert sets breadcrumb to internal error', () async {
@@ -1104,8 +1104,8 @@ void main() {
11041104

11051105
final breadcrumb = fixture.hub.scope.breadcrumbs.first;
11061106
expect(breadcrumb.data?['status'], 'internal_error');
1107-
expect(breadcrumb.type, 'error');
1108-
expect(breadcrumb.level, SentryLevel.error);
1107+
expect(breadcrumb.type, 'query');
1108+
expect(breadcrumb.level, SentryLevel.warning);
11091109
});
11101110

11111111
test('raw query sets breadcrumb to internal error', () async {
@@ -1120,8 +1120,8 @@ void main() {
11201120

11211121
final breadcrumb = fixture.hub.scope.breadcrumbs.first;
11221122
expect(breadcrumb.data?['status'], 'internal_error');
1123-
expect(breadcrumb.type, 'error');
1124-
expect(breadcrumb.level, SentryLevel.error);
1123+
expect(breadcrumb.type, 'query');
1124+
expect(breadcrumb.level, SentryLevel.warning);
11251125
});
11261126

11271127
test('raw query cursor sets breadcrumb to internal error', () async {
@@ -1137,8 +1137,8 @@ void main() {
11371137

11381138
final breadcrumb = fixture.hub.scope.breadcrumbs.first;
11391139
expect(breadcrumb.data?['status'], 'internal_error');
1140-
expect(breadcrumb.type, 'error');
1141-
expect(breadcrumb.level, SentryLevel.error);
1140+
expect(breadcrumb.type, 'query');
1141+
expect(breadcrumb.level, SentryLevel.warning);
11421142
});
11431143

11441144
test('raw update sets breadcrumb to internal error', () async {
@@ -1153,8 +1153,8 @@ void main() {
11531153

11541154
final breadcrumb = fixture.hub.scope.breadcrumbs.first;
11551155
expect(breadcrumb.data?['status'], 'internal_error');
1156-
expect(breadcrumb.type, 'error');
1157-
expect(breadcrumb.level, SentryLevel.error);
1156+
expect(breadcrumb.type, 'query');
1157+
expect(breadcrumb.level, SentryLevel.warning);
11581158
});
11591159

11601160
test('update sets breadcrumb to internal error', () async {
@@ -1170,8 +1170,8 @@ void main() {
11701170

11711171
final breadcrumb = fixture.hub.scope.breadcrumbs.first;
11721172
expect(breadcrumb.data?['status'], 'internal_error');
1173-
expect(breadcrumb.type, 'error');
1174-
expect(breadcrumb.level, SentryLevel.error);
1173+
expect(breadcrumb.type, 'query');
1174+
expect(breadcrumb.level, SentryLevel.warning);
11751175
});
11761176
});
11771177
}

0 commit comments

Comments
 (0)