Merge branch 'v9' into v9-feat/replace-custom-platform-checker

# Conflicts:
#	dart/lib/src/platform/_io_platform.dart
#	dart/lib/src/platform/_web_platform.dart
#	dart/lib/src/platform/platform.dart
#	dart/lib/src/runtime_checker.dart
#	dart/test/mocks/mock_platform.dart
#	dart/test/mocks/mock_platform_checker.dart
#	flutter/test/mocks.dart
#	flutter/test/profiling_test.dart
#	flutter/test/sentry_flutter_test.dart
#	flutter/test/sentry_native_channel_test.dart

Author: denrase

.github/ISSUE_TEMPLATE/BUG_REPORT.yml

@@ -1,6 +1,7 @@
 name: 🐞 Bug Report
 description: Tell us about something that's not working the way we (probably) intend.
 labels: ["Platform: Dart", "bug"]
+type: Bug
 body:
   - type: dropdown
     id: environment
@@ -94,7 +95,7 @@ body:
     id: submit-a-pr
     attributes:
       label: Are you willing to submit a PR?
-      description:  We accept contributions!
+      description: We accept contributions!
       options:
         - "Yes"
         - "No"

.github/ISSUE_TEMPLATE/FEATURE_REQUEST.yml

@@ -1,6 +1,7 @@
 name: 💡 Feature Request
 description: Tell us about a problem our SDK could solve but doesn't.
 labels: ["Platform: Dart", "enhancement"]
+type: Feature
 body:
   - type: textarea
     id: problem
@@ -24,7 +25,7 @@ body:
     id: submit-a-pr
     attributes:
       label: Are you willing to submit a PR?
-      description:  We accept contributions!
+      description: We accept contributions!
       options:
         - "Yes"
         - "No"

.github/workflows/analyze.yml

@@ -38,6 +38,9 @@ jobs:
         if: ${{ inputs.sdk == 'flutter' }}
 
       - run: ${{ inputs.sdk }} pub get
+      - run: ${{ inputs.sdk }} pub get
+        if: ${{ inputs.package == 'flutter' }}
+        working-directory: flutter/microbenchmarks
       - run: dart format --set-exit-if-changed ./
 
       - name: dart analyze

.github/workflows/flutter.yml

@@ -180,6 +180,6 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       # To recreate baseline run: detekt -i flutter/android,flutter/example/android -b flutter/config/detekt-bl.xml -cb
-      - uses: natiginfo/action-detekt-all@6bf4342ea96f638ecced05cf7d7dc48acdecc854 # [email protected].7
+      - uses: natiginfo/action-detekt-all@45229fbbe47eaff1160b6c956d7ffe14dc23c206 # [email protected].8
         with:
           args: -i flutter/android,flutter/example/android --baseline flutter/config/detekt-bl.xml --jvm-target 1.8 --build-upon-default-config --all-rules

.github/workflows/min_version_test.yml

@@ -55,6 +55,12 @@ jobs:
         with:
           flutter-version: "3.24.0"
 
+      - uses: ruby/setup-ruby@277ba2a127aba66d45bad0fa2dc56f80dbfedffa # [email protected]
+        with:
+          ruby-version: '3.1.2' # https://github.com/flutter/flutter/issues/109385#issuecomment-1212614125
+
+      - name: Update Pods
+        run: sudo gem update
       - name: Build iOS
         run: |
           cd min_version_test

.github/workflows/release.yml

@@ -19,7 +19,7 @@ jobs:
     steps:
       - name: Get auth token
         id: token
-        uses: actions/create-github-app-token@0d564482f06ca65fa9e77e2510873638c82206f2 # v1.11.5
+        uses: actions/create-github-app-token@21cfef2b496dd8ef5b904c159339626a10ad380e # v1.11.6
         with:
           app-id: ${{ vars.SENTRY_RELEASE_BOT_CLIENT_ID }}
           private-key: ${{ secrets.SENTRY_RELEASE_BOT_PRIVATE_KEY }}

.github/workflows/testflight.yml

@@ -16,7 +16,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: subosito/flutter-action@f2c4f6686ca8e8d6e6d0f28410eeef506ed66aff # [email protected]
       - run: xcodes select 15.0.1
-      - uses: ruby/setup-ruby@32110d4e311bd8996b2a82bf2a43b714ccc91777 # pin@v1.221.0
+      - uses: ruby/setup-ruby@277ba2a127aba66d45bad0fa2dc56f80dbfedffa # pin@v1.222.0
         with:
           ruby-version: '2.7.5'
           bundler-cache: true

.github/workflows/web-example-ghpages.yml

@@ -15,7 +15,7 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - uses: subosito/flutter-action@f2c4f6686ca8e8d6e6d0f28410eeef506ed66aff # [email protected]
-      - uses: bluefireteam/flutter-gh-pages@57815b17b371455ec1a98f075b71b4c6ba0a938c # pin@v8
+      - uses: bluefireteam/flutter-gh-pages@cf4a9312849577dbfd9df8f3d63d12ef6b09898e # pin@v9
         with:
           workingDir: flutter/example
           customArgs: --source-maps

CHANGELOG.md

@@ -2,6 +2,14 @@
 
 ## Unreleased 9.0.0
 
+- Move replay and privacy from experimental to options ([#2755](https://github.com/getsentry/sentry-dart/pull/2755))
+- Remove renderer from `flutter_context` ([#2751](https://github.com/getsentry/sentry-dart/pull/2751))
+- Cleanup platform mocking ([#2730](https://github.com/getsentry/sentry-dart/pull/2730))
+  - The `PlatformChecker` was renamed to `RuntimeChecker`
+  - Moved `PlatformChecker.platform` to `options.platform`
+
+## 9.0.0-alpha.1
+
 ### Breaking changes
 
 - Remove `SentryDisplayWidget` and manual TTID implementation ([#2668](https://github.com/getsentry/sentry-dart/pull/2668))
@@ -22,6 +30,7 @@
   - Responses are now only attached if size is below ~0.15mb
   - Responses are attached to the `Hint` object, which can be read in `beforeSend`/`beforeSendTransaction` callbacks via `hint.response`.
   - For now, only the `dio` integration is supported.
+- Enable privacy masking for screenshots by default ([#2728](https://github.com/getsentry/sentry-dart/pull/2728))
 
 ### Enhancements
 
@@ -32,14 +41,39 @@
 - Bump Android SDK from v7.20.1 to v8.1.0 ([#2650](https://github.com/getsentry/sentry-dart/pull/2650))
   - [changelog](https://github.com/getsentry/sentry-java/blob/main/CHANGELOG.md#810)
   - [diff](https://github.com/getsentry/sentry-java/compare/7.20.1...8.1.0)
-
 ## Unreleased
 
+
+### Enhancements
+
+- Add Flutter runtime information ([#2742](https://github.com/getsentry/sentry-dart/pull/2742))
+  - This works if the version of Flutter you're using includes [this code](https://github.com/flutter/flutter/pull/163761).
+
+### Fixes
+
+- Pass missing `captureFailedRequests` param to `FailedRequestInterceptor` ([#2744](https://github.com/getsentry/sentry-dart/pull/2744))
+
+
+## 8.14.0-beta.1
+
+### Behavioral changes
+
+- ⚠️ Auto IP assignment for `SentryUser` is now guarded by `sendDefaultPii` ([#2726](https://github.com/getsentry/sentry-dart/pull/2726))
+  - If you rely on Sentry automatically processing the IP address of the user, set `options.sendDefaultPii = true` or manually set the IP address of the `SentryUser` to `{{auto}}`
+- Adding the device name to Contexts is now guarded by `sendDefaultPii` ([#2741](https://github.com/getsentry/sentry-dart/pull/2741))
+  - Set `options.sendDefaultPii = true` if you want to have the device name reported
+
 ### Features
 
 - Disable `ScreenshotIntegration`, `WidgetsBindingIntegration` and `SentryWidget` in multi-view apps #2366 ([#2366](https://github.com/getsentry/sentry-dart/pull/2366))
 
-### Fixes 
+### Enhancements
+
+- Use `loadDebugImagesForAddresses` API for Android ([#2706](https://github.com/getsentry/sentry-dart/pull/2706))
+  - This reduces the envelope size and data transferred across method channels
+  - If debug images received by `loadDebugImagesForAddresses` are empty, the SDK loads all debug images as fallback
+
+### Fixes
 
 - Reference to `SentryWidgetsFlutterBinding` in warning message in `FramesTrackingIntegration` ([#2704](https://github.com/getsentry/sentry-dart/pull/2704))
 
@@ -71,9 +105,43 @@ final db = AppDatabase(executor);
 - Bump Native SDK from v0.7.19 to v0.7.20 ([#2652](https://github.com/getsentry/sentry-dart/pull/2652))
   - [changelog](https://github.com/getsentry/sentry-native/blob/master/CHANGELOG.md#0720)
   - [diff](https://github.com/getsentry/sentry-native/compare/0.7.19...0.7.20)
+- Bump Cocoa SDK from v8.44.0 to v8.45.0 ([#2718](https://github.com/getsentry/sentry-dart/pull/2718))
+  - [changelog](https://github.com/getsentry/sentry-cocoa/blob/main/CHANGELOG.md#8450)
+  - [diff](https://github.com/getsentry/sentry-cocoa/compare/8.44.0...8.45.0)
+
+## 8.13.2
+
+> [!WARNING]
+> This release contains an issue where Cold starts can be incorrectly reported as Warm starts on Android. We recommend staying on version 8.12.0 if you use this feature on Android.
+> See issue [#2769](https://github.com/getsentry/sentry-dart/issues/2769) for more details.
+
+### Fixes
+
+- `build_web_compiler` error ([#2736](https://github.com/getsentry/sentry-dart/pull/2736))
+  - Use `if (dart.library.html)` instead of `if (dart.html)` for imports
+
+## 8.13.1
+
+> [!WARNING]
+> This release contains an issue where Cold starts can be incorrectly reported as Warm starts on Android. We recommend staying on version 8.12.0 if you use this feature on Android.
+> See issue [#2769](https://github.com/getsentry/sentry-dart/issues/2769) for more details.
+
+### Fixes
+
+- Replay video interruption if a `navigation` breadcrumb is missing `to` route info ([#2720](https://github.com/getsentry/sentry-dart/pull/2720))
+
+### Dependencies
+
+- Bump Android SDK from v7.20.1 to v7.22.0 ([#2705](https://github.com/getsentry/sentry-dart/pull/2705))
+  - [changelog](https://github.com/getsentry/sentry-java/blob/7.x.x/CHANGELOG.md#7220)
+  - [diff](https://github.com/getsentry/sentry-java/compare/7.20.1...7.22.0)
 
 ## 8.13.0
 
+> [!WARNING]
+> This release contains an issue where Cold starts can be incorrectly reported as Warm starts on Android. We recommend staying on version 8.12.0 if you use this feature on Android.
+> See issue [#2769](https://github.com/getsentry/sentry-dart/issues/2769) for more details.
+
 ### Breaking changes
 
 - Remove Metrics API ([#2571](https://github.com/getsentry/sentry-dart/pull/2571))

dart/example_web/web/main.dart

@@ -24,6 +24,7 @@ Future<void> main() async {
 Future<void> runApp() async {
   print('runApp');
 
+  // ignore: deprecated_member_use
   document.querySelector('#output')?.text = 'Your Dart app is running.';
 
   await Sentry.addBreadcrumb(

dart/lib/sentry.dart

@@ -19,7 +19,7 @@ export 'src/integration.dart';
 export 'src/noop_isolate_error_integration.dart'
     if (dart.library.io) 'src/isolate_error_integration.dart';
 export 'src/performance_collector.dart';
-export 'src/platform_checker.dart';
+export 'src/runtime_checker.dart';
 export 'src/protocol.dart';
 export 'src/protocol/sentry_feedback.dart';
 export 'src/protocol/sentry_proxy.dart';

dart/lib/src/environment/environment_variables.dart

@@ -1,4 +1,4 @@
-import '../platform_checker.dart';
+import '../runtime_checker.dart';
 import '_io_environment_variables.dart'
     if (dart.library.js_interop) '_web_environment_variables.dart' as env;
 
@@ -28,7 +28,7 @@ abstract class EnvironmentVariables {
 
   /// Returns an environment based on the compilation mode of Dart or Flutter.
   /// This can be set as [SentryOptions.environment]
-  String environmentForMode(PlatformChecker checker) {
+  String environmentForMode(RuntimeChecker checker) {
     // We infer the environment based on the release/non-release and profile
     // constants.
 

dart/lib/src/event_processor/enricher/flutter_runtime.dart

@@ -0,0 +1,76 @@
+import '../../protocol/sentry_runtime.dart';
+
+// The Flutter version information can be fetched via Dart defines,
+// see
+//  - https://github.com/flutter/flutter/pull/140783
+//  - https://github.com/flutter/flutter/pull/163761
+//
+// This code lives in the Dart only Sentry code, since the code
+// doesn't require any Flutter dependency.
+// Additionally, this makes it work on background isolates in
+// Flutter, where one may not initialize the whole Flutter Sentry
+// SDK.
+// The const-ness of the properties below ensure that the code
+// is tree shaken in a non-Flutter environment.
+
+const _isFlutterRuntimeInformationAbsent = FlutterVersion.version == null ||
+    FlutterVersion.channel == null ||
+    FlutterVersion.frameworkRevision == null;
+
+const SentryRuntime? flutterRuntime = _isFlutterRuntimeInformationAbsent
+    ? null
+    : SentryRuntime(
+        name: 'Flutter',
+        version: '${FlutterVersion.version} (${FlutterVersion.channel})',
+        build: FlutterVersion.frameworkRevision,
+        rawDescription: '${FlutterVersion.version} (${FlutterVersion.channel}) '
+            '- Git hash ${FlutterVersion.frameworkRevision} '
+            '- Git URL ${FlutterVersion.gitUrl}',
+      );
+
+const SentryRuntime? dartFlutterRuntime = FlutterVersion.dartVersion == null
+    ? null
+    : SentryRuntime(name: 'Dart', version: FlutterVersion.dartVersion);
+
+/// Details about the Flutter version this app was compiled with,
+/// corresponding to the output of `flutter --version`.
+///
+/// When this Flutter version was build from a fork, or when Flutter runs in a
+/// custom embedder, these values might be unreliable.
+abstract class FlutterVersion {
+  const FlutterVersion._();
+
+  /// The Flutter version used to compile the app.
+  static const String? version = bool.hasEnvironment('FLUTTER_VERSION')
+      ? String.fromEnvironment('FLUTTER_VERSION')
+      : null;
+
+  /// The Flutter channel used to compile the app.
+  static const String? channel = bool.hasEnvironment('FLUTTER_CHANNEL')
+      ? String.fromEnvironment('FLUTTER_CHANNEL')
+      : null;
+
+  /// The URL of the Git repository from which Flutter was obtained.
+  static const String? gitUrl = bool.hasEnvironment('FLUTTER_GIT_URL')
+      ? String.fromEnvironment('FLUTTER_GIT_URL')
+      : null;
+
+  /// The Flutter framework revision, as a (short) Git commit ID.
+  static const String? frameworkRevision =
+      bool.hasEnvironment('FLUTTER_FRAMEWORK_REVISION')
+          ? String.fromEnvironment('FLUTTER_FRAMEWORK_REVISION')
+          : null;
+
+  /// The Flutter engine revision.
+  static const String? engineRevision =
+      bool.hasEnvironment('FLUTTER_ENGINE_REVISION')
+          ? String.fromEnvironment('FLUTTER_ENGINE_REVISION')
+          : null;
+
+  // This is included since [Platform.version](https://api.dart.dev/stable/dart-io/Platform/version.html)
+  // is not included on web platforms.
+  /// The Dart version used to compile the app.
+  static const String? dartVersion = bool.hasEnvironment('FLUTTER_DART_VERSION')
+      ? String.fromEnvironment('FLUTTER_DART_VERSION')
+      : null;
+}

dart/lib/src/event_processor/enricher/io_enricher_event_processor.dart

@@ -4,6 +4,7 @@ import 'package:meta/meta.dart';
 
 import '../../../sentry.dart';
 import 'enricher_event_processor.dart';
+import 'flutter_runtime.dart';
 import 'io_platform_memory.dart';
 
 EnricherEventProcessor enricherEventProcessor(SentryOptions options) {
@@ -63,12 +64,15 @@ class IoEnricherEventProcessor implements EnricherEventProcessor {
       version: _dartVersion,
       rawDescription: Platform.version,
     );
+    final flRuntime = flutterRuntime;
+
     if (runtimes == null) {
-      return [dartRuntime];
+      return [dartRuntime, if (flRuntime != null) flRuntime];
     }
     return [
       ...runtimes,
       dartRuntime,
+      if (flRuntime != null) flRuntime,
     ];
   }
 
@@ -78,25 +82,11 @@ class IoEnricherEventProcessor implements EnricherEventProcessor {
 
     String? executable;
     if (_options.sendDefaultPii) {
-      try {
-        // This throws sometimes for some reason
-        // https://github.com/flutter/flutter/issues/83921
-        executable = Platform.executable;
-      } catch (exception, stackTrace) {
-        _options.logger(
-          SentryLevel.error,
-          'Platform.executable couldn\'t be retrieved.',
-          exception: exception,
-          stackTrace: stackTrace,
-        );
-        if (_options.automatedTestMode) {
-          rethrow;
-        }
-      }
+      executable = Platform.executable;
     }
 
     return <String, dynamic>{
-      'compile_mode': _options.platformChecker.compileMode,
+      'compile_mode': _options.runtimeChecker.compileMode,
       if (packageConfig != null) 'package_config': packageConfig,
       // The following information could potentially contain PII
       if (_options.sendDefaultPii) ...{
@@ -112,7 +102,8 @@ class IoEnricherEventProcessor implements EnricherEventProcessor {
   SentryDevice _getDevice(SentryDevice? device) {
     final platformMemory = PlatformMemory(_options);
     return (device ?? SentryDevice()).copyWith(
-      name: device?.name ?? Platform.localHostname,
+      name: device?.name ??
+          (_options.sendDefaultPii ? Platform.localHostname : null),
       processorCount: device?.processorCount ?? Platform.numberOfProcessors,
       memorySize: device?.memorySize ?? platformMemory.getTotalPhysicalMemory(),
       freeMemory: device?.freeMemory ?? platformMemory.getFreePhysicalMemory(),

dart/lib/src/event_processor/enricher/io_platform_memory.dart

@@ -11,19 +11,19 @@ class PlatformMemory {
   final SentryOptions options;
 
   int? getTotalPhysicalMemory() {
-    if (options.platformChecker.platform.isLinux) {
+    if (options.platform.isLinux) {
       return _getLinuxMemInfoValue('MemTotal');
-    } else if (options.platformChecker.platform.isWindows) {
+    } else if (options.platform.isWindows) {
       return _getWindowsWmicValue('ComputerSystem', 'TotalPhysicalMemory');
     } else {
       return null;
     }
   }
 
   int? getFreePhysicalMemory() {
-    if (options.platformChecker.platform.isLinux) {
+    if (options.platform.isLinux) {
       return _getLinuxMemInfoValue('MemFree');
-    } else if (options.platformChecker.platform.isWindows) {
+    } else if (options.platform.isWindows) {
       return _getWindowsWmicValue('OS', 'FreePhysicalMemory');
     } else {
       return null;