Merge branch 'v9' into v9-feat/replace-custom-platform-checker

Author: denrase

.github/workflows/analyze.yml

@@ -32,7 +32,7 @@ jobs:
         working-directory: ${{ inputs.package }}
     steps:
       - uses: actions/checkout@v4
-      - uses: dart-lang/setup-dart@e630b99d28a3b71860378cafdc2a067c71107f94 # pin@v1
+      - uses: dart-lang/setup-dart@e51d8e571e22473a2ddebf0ef8a2123f0ab2c02c # pin@v1
         if: ${{ inputs.sdk == 'dart' }}
       - uses: subosito/flutter-action@f2c4f6686ca8e8d6e6d0f28410eeef506ed66aff # [email protected]
         if: ${{ inputs.sdk == 'flutter' }}

.github/workflows/diagrams.yml

@@ -7,7 +7,7 @@ jobs:
     runs-on: ubuntu-latest
     name: "Create class diagrams of all packages"
     steps:
-      - uses: dart-lang/setup-dart@e630b99d28a3b71860378cafdc2a067c71107f94 # pin@v1
+      - uses: dart-lang/setup-dart@e51d8e571e22473a2ddebf0ef8a2123f0ab2c02c # pin@v1
         with:
           sdk: stable
 

.github/workflows/e2e_dart.yml

@@ -38,7 +38,7 @@ jobs:
       matrix:
         sdk: [stable, beta]
     steps:
-      - uses: dart-lang/setup-dart@e630b99d28a3b71860378cafdc2a067c71107f94 # pin@v1
+      - uses: dart-lang/setup-dart@e51d8e571e22473a2ddebf0ef8a2123f0ab2c02c # pin@v1
         with:
           sdk: ${{ matrix.sdk }}
       - uses: actions/checkout@v4

.github/workflows/flutter-symbols.yml

@@ -21,7 +21,7 @@ jobs:
     steps:
       - uses: actions/checkout@v4
 
-      - uses: dart-lang/setup-dart@e630b99d28a3b71860378cafdc2a067c71107f94 # pin@v1
+      - uses: dart-lang/setup-dart@e51d8e571e22473a2ddebf0ef8a2123f0ab2c02c # pin@v1
 
       - run: dart pub get
 
@@ -33,7 +33,7 @@ jobs:
     steps:
       - uses: actions/checkout@v4
 
-      - uses: dart-lang/setup-dart@e630b99d28a3b71860378cafdc2a067c71107f94 # pin@v1
+      - uses: dart-lang/setup-dart@e51d8e571e22473a2ddebf0ef8a2123f0ab2c02c # pin@v1
 
       - run: dart pub get
 

.github/workflows/format-and-fix.yml

@@ -30,7 +30,7 @@ jobs:
         working-directory: ${{ matrix.package.name }}
     steps:
       - uses: actions/checkout@v4
-      - uses: dart-lang/setup-dart@e630b99d28a3b71860378cafdc2a067c71107f94 # pin@v1
+      - uses: dart-lang/setup-dart@e51d8e571e22473a2ddebf0ef8a2123f0ab2c02c # pin@v1
         if: ${{ matrix.package.sdk == 'dart' }}
       - uses: subosito/flutter-action@f2c4f6686ca8e8d6e6d0f28410eeef506ed66aff # [email protected]
         if: ${{ matrix.package.sdk == 'flutter' }}

.github/workflows/release.yml

@@ -19,7 +19,7 @@ jobs:
     steps:
       - name: Get auth token
         id: token
-        uses: actions/create-github-app-token@67e27a7eb7db372a1c61a7f9bdab8699e9ee57f7 # v1.11.3
+        uses: actions/create-github-app-token@0d564482f06ca65fa9e77e2510873638c82206f2 # v1.11.5
         with:
           app-id: ${{ vars.SENTRY_RELEASE_BOT_CLIENT_ID }}
           private-key: ${{ secrets.SENTRY_RELEASE_BOT_PRIVATE_KEY }}

.github/workflows/testflight.yml

@@ -16,7 +16,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: subosito/flutter-action@f2c4f6686ca8e8d6e6d0f28410eeef506ed66aff # [email protected]
       - run: xcodes select 15.0.1
-      - uses: ruby/setup-ruby@d781c1b4ed31764801bfae177617bb0446f5ef8d # pin@v1.218.0
+      - uses: ruby/setup-ruby@32110d4e311bd8996b2a82bf2a43b714ccc91777 # pin@v1.221.0
         with:
           ruby-version: '2.7.5'
           bundler-cache: true

CHANGELOG.md

@@ -8,15 +8,21 @@
 - Increase minimum SDK version requirements to Dart v3.5.0 and Flutter v3.24.0 ([#2643](https://github.com/getsentry/sentry-dart/pull/2643))
 - Remove screenshot option `attachScreenshotOnlyWhenResumed` ([#2664](https://github.com/getsentry/sentry-dart/pull/2664))
 - Remove deprecated `beforeScreenshot` ([#2662](https://github.com/getsentry/sentry-dart/pull/2662))
+- Remove old user feedback api ([#2686](https://github.com/getsentry/sentry-dart/pull/2686))
 - Remove deprecated loggers ([#2685](https://github.com/getsentry/sentry-dart/pull/2685))
 - Remove user segment ([#2687](https://github.com/getsentry/sentry-dart/pull/2687))
 - Enable JS SDK native integration by default ([#2688](https://github.com/getsentry/sentry-dart/pull/2688))
 - Remove `enableTracing` ([#2695](https://github.com/getsentry/sentry-dart/pull/2695))
 - Remove `options.autoAppStart` and `setAppStartEnd` ([#2680](https://github.com/getsentry/sentry-dart/pull/2680))
+- Bump Drift min version to `2.24.0` and use `QueryInterceptor` instead of `QueryExecutor` ([#2679](https://github.com/getsentry/sentry-dart/pull/2679))
 - Add hint for transactions ([#2675](https://github.com/getsentry/sentry-dart/pull/2675))
   - `BeforeSendTransactionCallback` now has a `Hint` parameter
 - Remove `dart:html` usage in favour of `package:web` ([#2710](https://github.com/getsentry/sentry-dart/pull/2710))
-
+- Remove max response body size ([#2709](https://github.com/getsentry/sentry-dart/pull/2709))
+  - Responses are now only attached if size is below ~0.15mb
+  - Responses are attached to the `Hint` object, which can be read in `beforeSend`/`beforeSendTransaction` callbacks via `hint.response`.
+  - For now, only the `dio` integration is supported.
+  
 ### Enhancements
 
 - Replay: improve Android native interop performance by using JNI ([#2670](https://github.com/getsentry/sentry-dart/pull/2670))
@@ -39,6 +45,16 @@
 
 ### Deprecations
 
+- Deprecate Drift `SentryQueryExecutor` ([#2715](https://github.com/getsentry/sentry-dart/pull/2715))
+  - This will be replace by `SentryQueryInterceptor` in the next major v9
+```dart
+// Example usage in Sentry Flutter v9
+final executor = NativeDatabase.memory().interceptWith(
+  SentryQueryInterceptor(databaseName: 'your_db_name'),
+);
+
+final db = AppDatabase(executor);
+```
 - Deprecate `autoAppStart` and `setAppStartEnd` ([#2681](https://github.com/getsentry/sentry-dart/pull/2681))
 
 ### Other

dart/lib/sentry.dart

@@ -5,60 +5,50 @@
 /// A pure Dart client for Sentry.io crash reporting.
 library;
 
-export 'src/run_zoned_guarded_integration.dart';
+export 'src/event_processor.dart';
+export 'src/exception_cause.dart';
+export 'src/exception_cause_extractor.dart';
+export 'src/exception_stacktrace_extractor.dart';
+export 'src/exception_type_identifier.dart';
+export 'src/hint.dart';
+export 'src/http_client/sentry_http_client.dart';
+export 'src/http_client/sentry_http_client_error.dart';
 export 'src/hub.dart';
-// useful for tests
 export 'src/hub_adapter.dart';
-export 'src/platform_checker.dart';
+export 'src/integration.dart';
 export 'src/noop_isolate_error_integration.dart'
     if (dart.library.io) 'src/isolate_error_integration.dart';
+export 'src/performance_collector.dart';
+export 'src/platform_checker.dart';
 export 'src/protocol.dart';
+export 'src/protocol/sentry_feedback.dart';
+export 'src/protocol/sentry_proxy.dart';
+export 'src/run_zoned_guarded_integration.dart';
 export 'src/scope.dart';
 export 'src/scope_observer.dart';
 export 'src/sentry.dart';
+export 'src/sentry_attachment/sentry_attachment.dart';
+export 'src/sentry_baggage.dart';
+export 'src/sentry_client.dart';
 export 'src/sentry_envelope.dart';
 export 'src/sentry_envelope_item.dart';
-export 'src/sentry_client.dart';
 export 'src/sentry_options.dart';
-// useful for integrations
+// ignore: invalid_export_of_internal_element
+export 'src/constants.dart';
+// ignore: invalid_export_of_internal_element
+export 'src/sentry_trace_origins.dart';
+export 'src/span_data_convention.dart';
+export 'src/spotlight.dart';
 export 'src/throwable_mechanism.dart';
-export 'src/transport/transport.dart';
-export 'src/integration.dart';
-export 'src/event_processor.dart';
-export 'src/http_client/sentry_http_client.dart';
-export 'src/http_client/sentry_http_client_error.dart';
-export 'src/sentry_attachment/sentry_attachment.dart';
-export 'src/sentry_user_feedback.dart';
-export 'src/utils/tracing_utils.dart';
-export 'src/performance_collector.dart';
-// tracing
 export 'src/tracing.dart';
-export 'src/hint.dart';
+export 'src/transport/transport.dart';
 export 'src/type_check_hint.dart';
-export 'src/sentry_baggage.dart';
-// exception extraction
-export 'src/exception_cause_extractor.dart';
-export 'src/exception_cause.dart';
-export 'src/exception_stacktrace_extractor.dart';
-export 'src/exception_type_identifier.dart';
-// URL
 // ignore: invalid_export_of_internal_element
-export 'src/utils/http_sanitizer.dart';
-// ignore: invalid_export_of_internal_element
-export 'src/utils/url_details.dart';
+export 'src/utils.dart';
 // ignore: invalid_export_of_internal_element
 export 'src/utils/http_header_utils.dart';
 // ignore: invalid_export_of_internal_element
-export 'src/sentry_trace_origins.dart';
-// ignore: invalid_export_of_internal_element
-export 'src/sentry_span_operations.dart';
+export 'src/utils/http_sanitizer.dart';
+export 'src/utils/tracing_utils.dart';
 // ignore: invalid_export_of_internal_element
-export 'src/utils.dart';
-// spotlight debugging
-export 'src/spotlight.dart';
-// proxy
-export 'src/protocol/sentry_proxy.dart';
-// feedback
-export 'src/protocol/sentry_feedback.dart';
-// constants
-export 'src/span_data_convention.dart';
+export 'src/utils/url_details.dart';

dart/lib/src/constants.dart

@@ -0,0 +1,30 @@
+import 'package:meta/meta.dart';
+
+@internal
+class SentrySpanOperations {
+  static const String uiLoad = 'ui.load';
+  static const String uiTimeToInitialDisplay = 'ui.load.initial_display';
+  static const String uiTimeToFullDisplay = 'ui.load.full_display';
+  static const String dbSqlQuery = 'db.sql.query';
+  static const String dbSqlTransaction = 'db.sql.transaction';
+  static const String dbSqlBatch = 'db.sql.batch';
+  static const String dbOpen = 'db.open';
+  static const String dbClose = 'db.close';
+}
+
+@internal
+class SentrySpanData {
+  static const String dbSystemKey = 'db.system';
+  static const String dbNameKey = 'db.name';
+
+  static const String dbSystemSqlite = 'db.sqlite';
+}
+
+@internal
+class SentrySpanDescriptions {
+  static const String dbTransaction = 'Transaction';
+  static String dbBatch({required List<String> statements}) =>
+      'Batch $statements';
+  static String dbOpen({required String dbName}) => 'Open database $dbName';
+  static String dbClose({required String dbName}) => 'Close database $dbName';
+}

dart/lib/src/hint.dart

@@ -1,5 +1,7 @@
+import 'protocol/sentry_response.dart';
 import 'sentry_attachment/sentry_attachment.dart';
-import 'sentry_options.dart';
+
+import 'package:meta/meta.dart';
 
 /// Hints are used in [BeforeSendCallback], [BeforeBreadcrumbCallback] and
 /// event processors.
@@ -41,6 +43,9 @@ import 'sentry_options.dart';
 /// };
 /// ```
 class Hint {
+  @internal
+  static const maxResponseBodySize = 157286;
+
   final Map<String, dynamic> _internalStorage = {};
 
   final List<SentryAttachment> attachments = [];
@@ -49,6 +54,8 @@ class Hint {
 
   SentryAttachment? viewHierarchy;
 
+  SentryResponse? response;
+
   Hint();
 
   factory Hint.withAttachment(SentryAttachment attachment) {
@@ -81,6 +88,12 @@ class Hint {
     return hint;
   }
 
+  factory Hint.withResponse(SentryResponse response) {
+    final hint = Hint();
+    hint.response = response;
+    return hint;
+  }
+
   // Key/Value Storage
 
   void addAll(Map<String, dynamic> keysAndValues) {

dart/lib/src/hub.dart

@@ -242,40 +242,6 @@ class Hub {
     return sentryId;
   }
 
-  @Deprecated(
-      'Will be removed in a future version. Use [captureFeedback] instead')
-  Future<void> captureUserFeedback(SentryUserFeedback userFeedback) async {
-    if (!_isEnabled) {
-      _options.logger(
-        SentryLevel.warning,
-        "Instance is disabled and this 'captureUserFeedback' call is a no-op.",
-      );
-      return;
-    }
-    if (userFeedback.eventId == SentryId.empty()) {
-      _options.logger(
-        SentryLevel.warning,
-        'Captured UserFeedback with empty id, dropping the feedback',
-      );
-      return;
-    }
-    try {
-      final item = _peek();
-
-      await item.client.captureUserFeedback(userFeedback);
-    } catch (exception, stacktrace) {
-      _options.logger(
-        SentryLevel.error,
-        'Error while capturing user feedback for ${userFeedback.eventId}',
-        exception: exception,
-        stackTrace: stacktrace,
-      );
-      if (_options.automatedTestMode) {
-        rethrow;
-      }
-    }
-  }
-
   /// Captures the feedback.
   Future<SentryId> captureFeedback(
     SentryFeedback feedback, {

dart/lib/src/hub_adapter.dart

@@ -11,7 +11,6 @@ import 'scope.dart';
 import 'sentry.dart';
 import 'sentry_client.dart';
 import 'sentry_options.dart';
-import 'sentry_user_feedback.dart';
 import 'tracing.dart';
 
 /// Hub adapter to make Integrations testable
@@ -112,12 +111,6 @@ class HubAdapter implements Hub {
   @override
   ISentrySpan? getSpan() => Sentry.currentHub.getSpan();
 
-  @override
-  // ignore: deprecated_member_use_from_same_package
-  Future<void> captureUserFeedback(SentryUserFeedback userFeedback) =>
-      // ignore: deprecated_member_use_from_same_package
-      Sentry.captureUserFeedback(userFeedback);
-
   @override
   ISentrySpan startTransactionWithContext(
     SentryTransactionContext transactionContext, {

dart/lib/src/noop_hub.dart

@@ -10,7 +10,6 @@ import 'protocol/sentry_feedback.dart';
 import 'scope.dart';
 import 'sentry_client.dart';
 import 'sentry_options.dart';
-import 'sentry_user_feedback.dart';
 import 'tracing.dart';
 
 class NoOpHub implements Hub {
@@ -86,10 +85,6 @@ class NoOpHub implements Hub {
   }) async =>
       SentryId.empty();
 
-  @override
-  // ignore: deprecated_member_use_from_same_package
-  Future<void> captureUserFeedback(SentryUserFeedback userFeedback) async {}
-
   @override
   Future<SentryId> captureFeedback(
     SentryFeedback feedback, {

dart/lib/src/noop_sentry_client.dart

@@ -7,7 +7,6 @@ import 'scope.dart';
 import 'sentry_client.dart';
 import 'sentry_envelope.dart';
 import 'sentry_trace_context_header.dart';
-import 'sentry_user_feedback.dart';
 
 class NoOpSentryClient implements SentryClient {
   NoOpSentryClient._();
@@ -51,10 +50,6 @@ class NoOpSentryClient implements SentryClient {
   Future<SentryId> captureEnvelope(SentryEnvelope envelope) async =>
       SentryId.empty();
 
-  @override
-  // ignore: deprecated_member_use_from_same_package
-  Future<void> captureUserFeedback(SentryUserFeedback userFeedback) async {}
-
   @override
   Future<void> close() async {}
 

dart/lib/src/protocol/contexts.dart

@@ -137,9 +137,10 @@ class Contexts extends MapView<String, dynamic> {
 
   set trace(SentryTraceContext? trace) => this[SentryTraceContext.type] = trace;
 
-  /// Response context for a HTTP response.
+  /// Response context for a HTTP response. Not added automatically.
   SentryResponse? get response => this[SentryResponse.type];
 
+  /// Use [Hint.response] in `beforeSend/beforeSendTransaction` to populate this value.
   set response(SentryResponse? value) => this[SentryResponse.type] = value;
 
   /// Feedback context for a feedback event.