Skip to content

Commit c70e01a

Browse files
authored
Fix file package min version (#1240)
1 parent 25d647d commit c70e01a

File tree

8 files changed

+18
-14
lines changed

8 files changed

+18
-14
lines changed

.github/workflows/file.yml

-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ jobs:
3131
fail-fast: false
3232
matrix:
3333
os: [ubuntu-latest, windows-latest, macos-latest]
34-
# removing beta because of Dart 2.19.0
3534
sdk: [stable]
3635
steps:
3736
- uses: dart-lang/setup-dart@6a218f2413a3e78e9087f638a238f6b40893203d # pin@v1

CHANGELOG.md

+6
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,11 @@
11
# Changelog
22

3+
## Unreleased
4+
5+
### Breaking Changes:
6+
7+
- sentry_file now requires Dart >= 2.19 ([#1240](https://github.com/getsentry/sentry-dart/pull/1240))
8+
39
## 6.18.3
410

511
### Fixes

file/lib/src/sentry_file.dart

+4-4
Original file line numberDiff line numberDiff line change
@@ -53,17 +53,17 @@ class SentryFile implements File {
5353
}
5454

5555
@override
56-
Future<File> create({bool recursive = false}) {
56+
Future<File> create({bool recursive = false, bool exclusive = false}) {
5757
return _wrap(
58-
() async => _file.create(recursive: recursive),
58+
() async => _file.create(recursive: recursive, exclusive: exclusive),
5959
'file.write',
6060
);
6161
}
6262

6363
@override
64-
void createSync({bool recursive = false}) {
64+
void createSync({bool recursive = false, bool exclusive = false}) {
6565
return _wrapSync(
66-
() => _file.createSync(recursive: recursive),
66+
() => _file.createSync(recursive: recursive, exclusive: exclusive),
6767
'file.write',
6868
);
6969
}

file/pubspec.yaml

+1-2
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,7 @@ repository: https://github.com/getsentry/sentry-dart
66
issue_tracker: https://github.com/getsentry/sentry-dart/issues
77

88
environment:
9-
# <2.19 because of https://github.com/dart-lang/sdk/issues/49647 breaking change
10-
sdk: '>=2.12.0 <2.19.0'
9+
sdk: '>=2.19.0 <3.0.0'
1110

1211
dependencies:
1312
sentry: 6.18.3

flutter/example/lib/main.dart

+4
Original file line numberDiff line numberDiff line change
@@ -330,6 +330,7 @@ class MainScaffold extends StatelessWidget {
330330
ElevatedButton(
331331
onPressed: () async {
332332
final id = await Sentry.captureMessage('UserFeedback');
333+
// ignore: use_build_context_synchronously
333334
await showDialog(
334335
context: context,
335336
builder: (context) {
@@ -547,6 +548,7 @@ Future<void> makeWebRequest(BuildContext context) async {
547548

548549
await transaction.finish(status: const SpanStatus.ok());
549550

551+
// ignore: use_build_context_synchronously
550552
await showDialog<void>(
551553
context: context,
552554
// gets tracked if using SentryNavigatorObserver
@@ -601,6 +603,7 @@ Future<void> makeWebRequestWithDio(BuildContext context) async {
601603
await span.finish();
602604
}
603605

606+
// ignore: use_build_context_synchronously
604607
await showDialog<void>(
605608
context: context,
606609
// gets tracked if using SentryNavigatorObserver
@@ -633,6 +636,7 @@ Future<void> showDialogWithTextAndImage(BuildContext context) async {
633636
);
634637
final text =
635638
await DefaultAssetBundle.of(context).loadString('assets/lorem-ipsum.txt');
639+
// ignore: use_build_context_synchronously
636640
await showDialog<void>(
637641
context: context,
638642
// gets tracked if using SentryNavigatorObserver

flutter/example/lib/user_feedback_dialog.dart

+2
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ class _UserFeedbackDialogState extends State<UserFeedbackDialog> {
3434
Text(
3535
"It looks like we're having some internal issues.",
3636
textAlign: TextAlign.center,
37+
// ignore: deprecated_member_use
3738
style: Theme.of(context).textTheme.headline6,
3839
),
3940
const SizedBox(height: 4),
@@ -43,6 +44,7 @@ class _UserFeedbackDialogState extends State<UserFeedbackDialog> {
4344
textAlign: TextAlign.center,
4445
style: Theme.of(context)
4546
.textTheme
47+
// ignore: deprecated_member_use
4648
.subtitle1
4749
?.copyWith(color: Colors.grey),
4850
),

min_version_test/lib/main.dart

+1-4
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,9 @@ import 'dart:io' if (dart.library.html) 'dart:html';
55
import 'package:logging/logging.dart';
66
import 'package:dio/dio.dart';
77

8-
import 'package:sentry/sentry.dart';
98
import 'package:sentry_flutter/sentry_flutter.dart';
109
import 'package:sentry_dio/sentry_dio.dart';
1110
import 'package:sentry_logging/sentry_logging.dart';
12-
import 'package:sentry_file/sentry_file.dart';
1311

1412
// ATTENTION: Change the DSN below with your own to see the events in Sentry. Get one at sentry.io
1513
const String _exampleDsn =
@@ -116,9 +114,8 @@ class _MyHomePageState extends State<MyHomePage> {
116114

117115
try {
118116
final file = File('response.txt');
119-
final sentryFile = file.sentryTrace();
120117
final response = await dio.get<String>('https://flutter.dev/');
121-
await sentryFile.writeAsString(response.data ?? 'no response');
118+
await file.writeAsString(response.data ?? 'no response');
122119

123120
await transaction.finish(status: SpanStatus.ok());
124121
} catch (exception, stackTrace) {

min_version_test/pubspec.yaml

-3
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ dependencies:
3434
sentry_flutter:
3535
sentry_dio:
3636
sentry_logging:
37-
sentry_file:
3837
dio: ^4.0.0
3938
logging: ^1.0.0
4039

@@ -53,8 +52,6 @@ dependency_overrides:
5352
path: ../dio
5453
sentry_logging:
5554
path: ../logging
56-
sentry_file:
57-
path: ../file
5855

5956
# For information on the generic Dart part of this file, see the
6057
# following page: https://dart.dev/tools/pub/pubspec

0 commit comments

Comments
 (0)