Skip to content

Commit d7dc4e5

Browse files
authored
Deprecate autoAppStart and setAppStartEnd (#2681)
* deprecate * update CHANGELOG
1 parent 515c540 commit d7dc4e5

File tree

5 files changed

+12
-0
lines changed

5 files changed

+12
-0
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@
22

33
## Unreleased
44

5+
### Deprecations
6+
7+
- Deprecate `autoAppStart` and `setAppStartEnd` ([#2681](https://github.com/getsentry/sentry-dart/pull/2681))
8+
59
### Other
610

711
- Remove macOS display refresh rate support ([#2628](https://github.com/getsentry/sentry-dart/pull/2628))

flutter/lib/src/integrations/native_app_start_integration.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ class NativeAppStartIntegration extends Integration<SentryFlutterOptions> {
1818
DateTime? _appStartEnd;
1919

2020
/// This timestamp marks the end of app startup. Either set by calling
21+
// ignore: deprecated_member_use_from_same_package
2122
/// [SentryFlutter.setAppStartEnd]. The [SentryFlutterOptions.autoAppStart]
2223
/// option needs to be false.
2324
@internal
@@ -43,6 +44,7 @@ class NativeAppStartIntegration extends Integration<SentryFlutterOptions> {
4344

4445
try {
4546
DateTime? appStartEnd;
47+
// ignore: deprecated_member_use_from_same_package
4648
if (options.autoAppStart) {
4749
// ignore: invalid_use_of_internal_member
4850
appStartEnd = DateTime.fromMicrosecondsSinceEpoch(timings.first

flutter/lib/src/sentry_flutter.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -230,6 +230,8 @@ mixin SentryFlutter {
230230
/// Manually set when your app finished startup. Make sure to set
231231
/// [SentryFlutterOptions.autoAppStart] to false on init. The timeout duration
232232
/// for this to work is 10 seconds.
233+
@Deprecated(
234+
'Will be removed in v9. This functionality will not be supported anymore.')
233235
static void setAppStartEnd(DateTime appStartEnd) {
234236
// ignore: invalid_use_of_internal_member
235237
final integrations = Sentry.currentHub.options.integrations

flutter/lib/src/sentry_flutter_options.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -179,6 +179,8 @@ class SentryFlutterOptions extends SentryOptions {
179179
/// first transaction. Set to false when configuring option to disable or if
180180
/// you want to set the end time of app startup manually using
181181
/// [SentryFlutter.setAppStartEnd].
182+
@Deprecated(
183+
'Will be removed in v9. In order to disable app starts disable it via option.removeIntegration(...) instead')
182184
bool autoAppStart = true;
183185

184186
/// Automatically attaches a screenshot when capturing an error or exception.

flutter/test/integrations/native_app_start_integration_test.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,7 @@ void main() {
118118

119119
test('with disabled auto app start waits until appStartEnd is set',
120120
() async {
121+
// ignore: deprecated_member_use_from_same_package
121122
fixture.options.autoAppStart = false;
122123

123124
fixture.callIntegration();
@@ -137,6 +138,7 @@ void main() {
137138
});
138139

139140
test('with disabled auto app start waits until timeout', () async {
141+
// ignore: deprecated_member_use_from_same_package
140142
fixture.options.autoAppStart = false;
141143

142144
fixture.callIntegration();

0 commit comments

Comments
 (0)