Skip to content

Commit e3d9076

Browse files
authored
Update root name (#1934)
* Update root name * Update root name * update
1 parent 3d30a22 commit e3d9076

File tree

4 files changed

+9
-4
lines changed

4 files changed

+9
-4
lines changed

CHANGELOG.md

+6-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
## Unreleased
44

5-
## Features
5+
### Features
66

77
- Add TTFD (time to full display), which allows you to measure the time it takes to render the full screen ([#1920](https://github.com/getsentry/sentry-dart/pull/1920))
88
- Requires using the [routing instrumentation](https://docs.sentry.io/platforms/flutter/integrations/routing-instrumentation/).
@@ -23,6 +23,11 @@
2323
- The `dio` integration and `SentryHttpClient` now take an additional `captureFailedRequests` option.
2424
- This is useful if you want to disable this option on native and only enable it on `dio` for example.
2525

26+
### Improvements
27+
28+
- Update root name for navigator observer ([#1934](https://github.com/getsentry/sentry-dart/pull/1934))
29+
- The root name for transactions is now `root /` instead of `root ("/")`.
30+
2631
### Dependencies
2732

2833
- Bump Android SDK from v7.5.0 to v7.6.0 ([#1927](https://github.com/getsentry/sentry-dart/pull/1927))

flutter/lib/src/navigation/sentry_navigator_observer.dart

+1-1
Original file line numberDiff line numberDiff line change
@@ -224,7 +224,7 @@ class SentryNavigatorObserver extends RouteObserver<PageRoute<dynamic>> {
224224
}
225225

226226
if (name == '/') {
227-
name = 'root ("/")';
227+
name = 'root /';
228228
}
229229
final transactionContext = SentryTransactionContext(
230230
name,

flutter/test/navigation/sentry_display_widget_test.dart

+1-1
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ void main() {
8181
expect(ttidSpan.context.operation,
8282
SentrySpanOperations.uiTimeToInitialDisplay);
8383
expect(ttidSpan.finished, isTrue);
84-
expect(ttidSpan.context.description, 'root ("/") initial display');
84+
expect(ttidSpan.context.description, 'root / initial display');
8585
expect(ttidSpan.origin, SentryTraceOrigins.autoUiTimeToDisplay);
8686

8787
expect(ttidSpan.startTimestamp, appStartInfo.start);

flutter/test/sentry_navigator_observer_test.dart

+1-1
Original file line numberDiff line numberDiff line change
@@ -530,7 +530,7 @@ void main() {
530530
onFinish: anyNamed('onFinish'),
531531
)).captured.single as SentryTransactionContext;
532532

533-
expect(context.name, 'root ("/")');
533+
expect(context.name, 'root /');
534534

535535
hub.configureScope((scope) {
536536
expect(scope.span, span);

0 commit comments

Comments
 (0)