-
-
Notifications
You must be signed in to change notification settings - Fork 255
PlatformException.message
should be treated like PlatformException.stacktrace
#1708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Do you have an example of how it's misused? Not sure if I understand correctly if |
Sure. Here's an example where a native stacktrace is passed to Flutter in the ![]() As you can see, it's not really well formatted and Sentry could do better. Here's an example of how it looks like when the native stacktrace is passed via the ![]() It should be a straight forward change in the following file https://github.com/getsentry/sentry-dart/blob/955541a50762f04c301c83eb25aef0077742c29a/flutter/lib/src/event_processor/android_platform_exception_event_processor.dart Basically the new logic should be in case |
I see, makes sense if it is parsed as a fallback 👍 |
Problem Statement
In theory, only
PlatformException.stacktrace
should contain a stacktrace. However, in practice I see a lot of plugins misusing thePlatformException.message
field for stacktraces.Solution Brainstorm
Therefore, it would be nice if the
PlatformException.message
field could be treated like thePlatformException.stacktrace
field.Are you willing to submit a PR?
Yes
The text was updated successfully, but these errors were encountered: