Skip to content

Basic Flutter package support for Desktop #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bruno-garcia opened this issue Mar 15, 2021 · 4 comments
Closed

Basic Flutter package support for Desktop #362

bruno-garcia opened this issue Mar 15, 2021 · 4 comments
Assignees

Comments

@bruno-garcia
Copy link
Member

The dart package supports them all:
image

sentry_flutter doesn't:

image

Probably a matter of adding the platforms here:

platforms:
android:
pluginClass: SentryFlutterPlugin
package: io.sentry.flutter
ios:
pluginClass: SentryFlutterPlugin
web:
pluginClass: SentryFlutterWeb
fileName: sentry_flutter_web.dart

To at least explicitly support it. Device context etc can come later.

@ueman
Copy link
Collaborator

ueman commented Mar 15, 2021

Ideally this should be done together with #288 to get basic breadcrumb support out of the box.

@JigneshWorld
Copy link
Contributor

These plus plugins maintained by flutter community can help to add device or package context info by replacing currently used package_info plugin.

Important: As of January 2021, the Flutter team is no longer accepting non-critical PRs for the original set of plugins in flutter/plugins, and instead they should be submitted in this project. You can read more about this announcement here. as well as in the Flutter 2 announcement blog post.

@ueman
Copy link
Collaborator

ueman commented Mar 17, 2021

Links for reference:
https://github.com/flutter/plugins/blob/master/CONTRIBUTING.md#important-note
https://medium.com/flutter/whats-new-in-flutter-2-0-fe8e95ecc65

@bruno-garcia
Copy link
Member Author

These plus plugins maintained by flutter community can help to add device or package context info by replacing currently used package_info plugin.

Important: As of January 2021, the Flutter team is no longer accepting non-critical PRs for the original set of plugins in flutter/plugins, and instead they should be submitted in this project. You can read more about this announcement here. as well as in the Flutter 2 announcement blog post.

Yes plus plugins is the way to go.
Particularly on the next major bump, we should make the switch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants