From 368a1838a0500f2415baa4160109b789593dcbda Mon Sep 17 00:00:00 2001 From: Bruno Garcia Date: Tue, 13 Oct 2020 21:53:34 -0400 Subject: [PATCH 1/5] fix: dart ci --- .github/workflows/dart.yml | 24 +++++++++--------------- 1 file changed, 9 insertions(+), 15 deletions(-) diff --git a/.github/workflows/dart.yml b/.github/workflows/dart.yml index 0c254ed012..085495ea07 100644 --- a/.github/workflows/dart.yml +++ b/.github/workflows/dart.yml @@ -11,6 +11,8 @@ jobs: build: name: Build ${{matrix.sdk}} on ${{matrix.os}} runs-on: ${{ matrix.os }} + env: + working-directory: ./dart strategy: fail-fast: false matrix: @@ -32,24 +34,16 @@ jobs: with: release-channel: ${{ matrix.sdk }} - uses: actions/checkout@v2 - - run: | - cd dart - pub get + - run: pub get - name: Test on Dart VM and collect code coverage - run: | - cd dart - pub run test_coverage + uses: stelynx/dart-full-coverage@v1.0.3 + with: + package: sentry - uses: codecov/codecov-action@v1 - name: Test on Chrome - run: | - cd dart - pub run test -p vm test/* - - run: | - cd dart - dartanalyzer --fatal-warnings ./ - - run: | - cd dart - dartfmt -n --set-exit-if-changed ./ + run: pub run test -p chrome test/* + - run: dartanalyzer --fatal-warnings ./ + - run: dartfmt -n --set-exit-if-changed ./ package-analysis: runs-on: ubuntu-latest steps: From 1ad341823cd41d1db2b89d681cf29f0e8953c593 Mon Sep 17 00:00:00 2001 From: Bruno Garcia Date: Tue, 13 Oct 2020 21:59:25 -0400 Subject: [PATCH 2/5] work dir --- .github/workflows/dart.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/dart.yml b/.github/workflows/dart.yml index 085495ea07..30e3d0b59b 100644 --- a/.github/workflows/dart.yml +++ b/.github/workflows/dart.yml @@ -11,8 +11,9 @@ jobs: build: name: Build ${{matrix.sdk}} on ${{matrix.os}} runs-on: ${{ matrix.os }} - env: - working-directory: ./dart + defaults: + env: + working-directory: ./dart strategy: fail-fast: false matrix: From 680f67ba89c4d40bf78b9d9f2baeec6ee4e709bd Mon Sep 17 00:00:00 2001 From: Bruno Garcia Date: Tue, 13 Oct 2020 22:01:59 -0400 Subject: [PATCH 3/5] wip --- .github/workflows/dart.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/dart.yml b/.github/workflows/dart.yml index 30e3d0b59b..a0a781b088 100644 --- a/.github/workflows/dart.yml +++ b/.github/workflows/dart.yml @@ -12,8 +12,7 @@ jobs: name: Build ${{matrix.sdk}} on ${{matrix.os}} runs-on: ${{ matrix.os }} defaults: - env: - working-directory: ./dart + working-directory: ./dart strategy: fail-fast: false matrix: From 848641338a625a8d6c70a3f6c7bbf8848bc49916 Mon Sep 17 00:00:00 2001 From: Bruno Garcia Date: Tue, 13 Oct 2020 22:03:26 -0400 Subject: [PATCH 4/5] wip --- .github/workflows/dart.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/dart.yml b/.github/workflows/dart.yml index a0a781b088..fa6042cecf 100644 --- a/.github/workflows/dart.yml +++ b/.github/workflows/dart.yml @@ -12,7 +12,8 @@ jobs: name: Build ${{matrix.sdk}} on ${{matrix.os}} runs-on: ${{ matrix.os }} defaults: - working-directory: ./dart + run: + working-directory: ./dart strategy: fail-fast: false matrix: From dc9b7b9d7d9d92eaeaf4d5597f92f92cd8940876 Mon Sep 17 00:00:00 2001 From: Bruno Garcia Date: Tue, 13 Oct 2020 22:07:39 -0400 Subject: [PATCH 5/5] wip --- .github/workflows/dart.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/dart.yml b/.github/workflows/dart.yml index fa6042cecf..8dbb772967 100644 --- a/.github/workflows/dart.yml +++ b/.github/workflows/dart.yml @@ -40,6 +40,7 @@ jobs: uses: stelynx/dart-full-coverage@v1.0.3 with: package: sentry + path: dart # seems the action does a cd {BLA} and ignores the workdir we set - uses: codecov/codecov-action@v1 - name: Test on Chrome run: pub run test -p chrome test/*