From 5e1467aab15db15755ba0ea1148475a9f3799bf2 Mon Sep 17 00:00:00 2001 From: GIancarlo Buenaflor Date: Wed, 13 Mar 2024 16:42:24 +0100 Subject: [PATCH 1/3] Update root name --- flutter/lib/src/navigation/sentry_navigator_observer.dart | 2 +- flutter/test/sentry_navigator_observer_test.dart | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/flutter/lib/src/navigation/sentry_navigator_observer.dart b/flutter/lib/src/navigation/sentry_navigator_observer.dart index 0af0a76381..aaa4c86889 100644 --- a/flutter/lib/src/navigation/sentry_navigator_observer.dart +++ b/flutter/lib/src/navigation/sentry_navigator_observer.dart @@ -224,7 +224,7 @@ class SentryNavigatorObserver extends RouteObserver> { } if (name == '/') { - name = 'root ("/")'; + name = 'root /'; } final transactionContext = SentryTransactionContext( name, diff --git a/flutter/test/sentry_navigator_observer_test.dart b/flutter/test/sentry_navigator_observer_test.dart index a14255392e..1b41833e20 100644 --- a/flutter/test/sentry_navigator_observer_test.dart +++ b/flutter/test/sentry_navigator_observer_test.dart @@ -530,7 +530,7 @@ void main() { onFinish: anyNamed('onFinish'), )).captured.single as SentryTransactionContext; - expect(context.name, 'root ("/")'); + expect(context.name, 'root /'); hub.configureScope((scope) { expect(scope.span, span); From 7da0dd3e4923f96ac1bcfe22cb5f13273bb5c01d Mon Sep 17 00:00:00 2001 From: GIancarlo Buenaflor Date: Wed, 13 Mar 2024 16:51:57 +0100 Subject: [PATCH 2/3] Update root name --- CHANGELOG.md | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 04cb41f568..2308bf0d97 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,7 +2,7 @@ ## Unreleased -## Features +### Features - Add TTFD (time to full display), which allows you to measure the time it takes to render the full screen ([#1920](https://github.com/getsentry/sentry-dart/pull/1920)) - Requires using the [routing instrumentation](https://docs.sentry.io/platforms/flutter/integrations/routing-instrumentation/). @@ -23,6 +23,11 @@ - The `dio` integration and `SentryHttpClient` now take an additional `captureFailedRequests` option. - This is useful if you want to disable this option on native and only enable it on `dio` for example. +### Improvements + +- Update root name for navigator observer ([#1934](https://github.com/getsentry/sentry-dart/pull/1934)) + - The root name for transactions is now `root /` instead of `root ("/")`. + ### Dependencies - Bump Android SDK from v7.5.0 to v7.6.0 ([#1927](https://github.com/getsentry/sentry-dart/pull/1927)) From cf99c39fa9a1fb152e65d83cfaa1320a4f8b8e7e Mon Sep 17 00:00:00 2001 From: GIancarlo Buenaflor Date: Wed, 13 Mar 2024 16:53:47 +0100 Subject: [PATCH 3/3] update --- flutter/test/navigation/sentry_display_widget_test.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/flutter/test/navigation/sentry_display_widget_test.dart b/flutter/test/navigation/sentry_display_widget_test.dart index 6fb61c5b8f..b9c2eb37cb 100644 --- a/flutter/test/navigation/sentry_display_widget_test.dart +++ b/flutter/test/navigation/sentry_display_widget_test.dart @@ -81,7 +81,7 @@ void main() { expect(ttidSpan.context.operation, SentrySpanOperations.uiTimeToInitialDisplay); expect(ttidSpan.finished, isTrue); - expect(ttidSpan.context.description, 'root ("/") initial display'); + expect(ttidSpan.context.description, 'root / initial display'); expect(ttidSpan.origin, SentryTraceOrigins.autoUiTimeToDisplay); expect(ttidSpan.startTimestamp, appStartInfo.start);