Skip to content

Commit 67d5840

Browse files
feat(dev-docs): Add LOGAF scale to code review (#12437)
Add the LOGAF scale to the code review docs, as multiple SDK develop docs mention the LOGAF scale. Instead of having it duplicated, we have one central place explaining it.
1 parent ad23515 commit 67d5840

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

develop-docs/engineering-practices/code-review.mdx

+8
Original file line numberDiff line numberDiff line change
@@ -216,3 +216,11 @@ Please be pragmatic, and consider the cost of each incremental request for chang
216216
- Feedback is objective and actionable
217217
- Submitter responds to feedback and makes changes promptly
218218
- PR is approved and merged within 48 hours
219+
220+
### LOGAF Scale
221+
222+
For feedback in PRs, you can use the [LOGAF scale](https://blog.danlew.net/2020/04/15/the-logaf-scale/) to specify how important a comment is:
223+
224+
- `l`: low - nitpick. You may address this comment, but you don't have to.
225+
- `m`: medium - normal comment. Worth addressing and fixing.
226+
- `h`: high - Very important. We must not merge this PR without addressing this issue.

0 commit comments

Comments
 (0)