Skip to content

Commit aaa0882

Browse files
authored
Conditional changelog builds (#11770)
* move prisma seed config to changelog package.json * get rid of prisma related dependencies and scripts from the main app package.json * fail seed script on errors * skip changelog builds on related source code chnage * simple skip build logic for changelog
1 parent 0717c17 commit aaa0882

File tree

4 files changed

+16
-8
lines changed

4 files changed

+16
-8
lines changed

apps/changelog/package.json

+3
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,9 @@
1414
"lint": "next lint",
1515
"migrate:dev": "dotenv -e .env.development -- yarn prisma migrate reset"
1616
},
17+
"prisma": {
18+
"seed": "node prisma/seed/seed.mjs"
19+
},
1720
"dependencies": {
1821
"@auth/prisma-adapter": "^1.2.0",
1922
"@google-cloud/storage": "^7.7.0",

apps/changelog/prisma/seed/seed.mjs

+1
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,7 @@ async function seed() {
7676
console.log('Seed data created successfully!');
7777
} catch (error) {
7878
console.error('Error seeding data:', error);
79+
process.exit(1);
7980
} finally {
8081
await prisma.$disconnect();
8182
}

package.json

+1-8
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,9 @@
1818
"dev": "yarn enforce-redirects && concurrently \"yarn sidecar\" \"node ./src/hotReloadWatcher.mjs\" \"next dev\"",
1919
"dev:developer-docs": "yarn enforce-redirects && NEXT_PUBLIC_DEVELOPER_DOCS=1 yarn dev",
2020
"build:developer-docs": "yarn enforce-redirects && git submodule init && git submodule update && NEXT_PUBLIC_DEVELOPER_DOCS=1 yarn build",
21-
"build": "yarn enforce-redirects && prisma generate && next build",
21+
"build": "yarn enforce-redirects && next build",
2222
"vercel:build:developer-docs": "yarn enforce-redirects && git submodule init && git submodule update && NEXT_PUBLIC_DEVELOPER_DOCS=1 yarn build",
2323
"start": "next start",
24-
"migrate:dev": "dotenv -e .env.development -- yarn prisma migrate reset",
2524
"lint": "next lint",
2625
"lint:ts": "tsc --skipLibCheck",
2726
"lint:docs": "bin/lint-docs.ts",
@@ -35,12 +34,8 @@
3534
"test:ci": "vitest run",
3635
"enforce-redirects": "node ./scripts/no-vercel-json-redirects.mjs"
3736
},
38-
"prisma": {
39-
"seed": "node prisma/seed/seed.mjs"
40-
},
4137
"dependencies": {
4238
"@ariakit/react": "^0.4.5",
43-
"@auth/prisma-adapter": "^1.2.0",
4439
"@emotion/core": "^11.0.0",
4540
"@emotion/react": "^11.11.0",
4641
"@emotion/styled": "^11.0.0",
@@ -50,7 +45,6 @@
5045
"@next/mdx": "^14.2.4",
5146
"@popperjs/core": "^2.11.8",
5247
"@prettier/plugin-xml": "^3.3.1",
53-
"@prisma/client": "^5.8.1",
5448
"@radix-ui/colors": "^3.0.0",
5549
"@radix-ui/react-collapsible": "^1.0.3",
5650
"@radix-ui/react-dropdown-menu": "^2.0.6",
@@ -126,7 +120,6 @@
126120
"jest-environment-jsdom": "^29.5.0",
127121
"postcss": "^8.4.33",
128122
"prettier": "^3.2.4",
129-
"prisma": "^5.8.1",
130123
"tailwindcss": "^3.4.1",
131124
"ts-node": "^10.9.1",
132125
"typescript": "^5",

skip-build.sh

+11
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,17 @@ docs_diff_status=$(git diff HEAD^ HEAD --quiet -- docs includes platform-include
1414
# have changes occurred outside of the content directories
1515
non_content_diff_status=$(git diff HEAD^ HEAD --name-only | grep -vE '^(docs/|platform-includes/|includes/|develop-docs/)' | wc -l)
1616

17+
# apps/changelog changes or workspace deps changes (yarn.lock)
18+
changelog_diff_status=$(git diff HEAD^ HEAD --name-only | grep -E '^(apps/changelog/|yarn.lock)' | wc -l)
19+
20+
if [[ "$NEXT_PUBLIC_CHANGELOG" == "1" ]] ; then
21+
if [[ $changelog_diff_status -gt 0 ]] ; then
22+
exit 1
23+
else
24+
exit 0
25+
fi
26+
fi
27+
1728
# always build on changes in non-content related directories
1829
if [[ $non_content_diff_status -gt 0 ]] ; then
1930
exit 1

0 commit comments

Comments
 (0)